From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from casper.infradead.org ([85.118.1.10]:57728 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726504AbeLDOci (ORCPT ); Tue, 4 Dec 2018 09:32:38 -0500 Date: Tue, 4 Dec 2018 12:32:32 -0200 From: Mauro Carvalho Chehab To: Sakari Ailus Cc: linux-media@vger.kernel.org, bingbu.cao@intel.com Subject: Re: [PATCH 1/1] v4l uapi: Make "Vertical Colour Bars" menu item a little more generic Message-ID: <20181204123232.7901ab7e@coco.lan> In-Reply-To: <20181204134506.21529-1-sakari.ailus@linux.intel.com> References: <20181204134506.21529-1-sakari.ailus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em Tue, 4 Dec 2018 15:45:06 +0200 Sakari Ailus escreveu: > The test pattern could contain a different number of colour bars than > eight, make the entry more useful by removing "Eight " from the name. > > Signed-off-by: Sakari Ailus > --- > include/uapi/linux/v4l2-controls.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h > index acb2a57fa5d6..88f2759c2ce4 100644 > --- a/include/uapi/linux/v4l2-controls.h > +++ b/include/uapi/linux/v4l2-controls.h > @@ -1016,7 +1016,7 @@ enum v4l2_jpeg_chroma_subsampling { > #define V4L2_CID_TEST_PATTERN (V4L2_CID_IMAGE_PROC_CLASS_BASE + 3) > #define V4L2_TEST_PATTERN_DISABLED "Disabled" > #define V4L2_TEST_PATTERN_SOLID_COLOUR "Solid Colour" > -#define V4L2_TEST_PATTERN_VERT_COLOUR_BARS "Eight Vertical Colour Bars" > +#define V4L2_TEST_PATTERN_VERT_COLOUR_BARS "Vertical Colour Bars" No, we can't do that. This is on an uAPI file. We should, instead, create another #define for non-eight vertical color bars. Before you say, yeah, I agree that we messed this one, as the defined name doesn't mention 8 bars... I would, instead, do something like: -#define V4L2_TEST_PATTERN_VERT_COLOUR_BARS "Eight Vertical Colour Bars" +#define V4L2_TEST_PATTERN_VERT_8_COLOUR_BARS "Eight Vertical Colour Bars" +#define V4L2_TEST_PATTERN_VERT_N_COLOUR_BARS "Vertical Colour Bars" + + /* Kept for backward-compatibility */ +#define V4L2_TEST_PATTERN_VERT_COLOUR_BARS V4L2_TEST_PATTERN_VERT_8_COLOUR_BARS And, of course, update the documentation accordingly. > #define V4L2_TEST_PATTERN_VERT_COLOUR_BARS_FADE_TO_GREY "Colour Bars With Fade to Grey" > #define V4L2_TEST_PATTERN_PN9 "Pseudorandom Sequence (PN9)" > #define V4L2_CID_DEINTERLACING_MODE (V4L2_CID_IMAGE_PROC_CLASS_BASE + 4) Thanks, Mauro