From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33136C07E85 for ; Tue, 4 Dec 2018 19:22:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1D86206B7 for ; Tue, 4 Dec 2018 19:22:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hagXzcwc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1D86206B7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MH4+1jyAhbd4NxKb4lI90ByvvtVBlecmaPPW09d4Rf0=; b=hagXzcwc17dePR nm12UN5Lml6OqWG7FWvwc5WWqPLLb5kxK5UxHQtNCC+W59TDq9ABWuELrO7s3akiSHESO9HoykPLL RmG16W2Pjms0L5RVDDjLu2SbdW3bHXiHBrM9Phajw9EFgBfFT934zancy1Uy7Cf1wWfut4RdbJKSR EBOMm4nnXkz7OFMepNdmHUnf8bfK3thJ+SMlekQv2MwQ4nZStFP0y6JlSuIdLMj06i8V+zlSFhcdA S/LUtxrNcTS2+uXaemlzy+NC9qbXMKUwgmDvf+U2sYELcRsPCpSPv5ltpniCEMIq4RDPvEDhEl/J7 HCXzwO68x/NhTb1CtyWQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gUGGd-0004rk-9O; Tue, 04 Dec 2018 19:21:59 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gUGGZ-0004mr-En for linux-arm-kernel@lists.infradead.org; Tue, 04 Dec 2018 19:21:56 +0000 Received: from vmware.local.home (unknown [208.91.3.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CAA32206B7; Tue, 4 Dec 2018 19:21:44 +0000 (UTC) Date: Tue, 4 Dec 2018 14:21:42 -0500 From: Steven Rostedt To: Anders Roxell Subject: Re: [PATCH] tracing: add cond_resched to ftrace_replace_code() Message-ID: <20181204142142.4e2e2169@vmware.local.home> In-Reply-To: <20181204141908.76e7afa5@vmware.local.home> References: <20181204191229.6851-1-anders.roxell@linaro.org> <20181204141908.76e7afa5@vmware.local.home> X-Mailer: Claws Mail 3.15.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181204_112155_545398_8F6460F4 X-CRM114-Status: GOOD ( 10.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: keescook@chromium.org, arnd@arndb.de, catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, mingo@redhat.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 4 Dec 2018 14:19:08 -0500 Steven Rostedt wrote: > > @@ -2435,6 +2438,13 @@ void __weak ftrace_replace_code(int enable) > > /* Stop processing */ > > return; > > } > > + /* > > + * Some archs calls this function with interrupts or preemption > > + * disabled. Howeve, other archs don't and this can cause a typo "However". But could you write it this way: "However, for other archs that can preempt, this can cause an tremendous unneeded latency." Thanks! -- Steve > > + * tremendous unneeded latency. > > + */ > > Actually, could you move the comment up where schedulable gets set? > > Thanks! > > -- Steve > > > + if (schedulable) > > + cond_resched(); > > } while_for_each_ftrace_rec(); > > } > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61AEDC04EB8 for ; Tue, 4 Dec 2018 19:21:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2E564214C1 for ; Tue, 4 Dec 2018 19:21:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E564214C1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726148AbeLDTVq (ORCPT ); Tue, 4 Dec 2018 14:21:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:36652 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725841AbeLDTVp (ORCPT ); Tue, 4 Dec 2018 14:21:45 -0500 Received: from vmware.local.home (unknown [208.91.3.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CAA32206B7; Tue, 4 Dec 2018 19:21:44 +0000 (UTC) Date: Tue, 4 Dec 2018 14:21:42 -0500 From: Steven Rostedt To: Anders Roxell Cc: mingo@redhat.com, catalin.marinas@arm.com, will.deacon@arm.com, keescook@chromium.org, arnd@arndb.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] tracing: add cond_resched to ftrace_replace_code() Message-ID: <20181204142142.4e2e2169@vmware.local.home> In-Reply-To: <20181204141908.76e7afa5@vmware.local.home> References: <20181204191229.6851-1-anders.roxell@linaro.org> <20181204141908.76e7afa5@vmware.local.home> X-Mailer: Claws Mail 3.15.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 4 Dec 2018 14:19:08 -0500 Steven Rostedt wrote: > > @@ -2435,6 +2438,13 @@ void __weak ftrace_replace_code(int enable) > > /* Stop processing */ > > return; > > } > > + /* > > + * Some archs calls this function with interrupts or preemption > > + * disabled. Howeve, other archs don't and this can cause a typo "However". But could you write it this way: "However, for other archs that can preempt, this can cause an tremendous unneeded latency." Thanks! -- Steve > > + * tremendous unneeded latency. > > + */ > > Actually, could you move the comment up where schedulable gets set? > > Thanks! > > -- Steve > > > + if (schedulable) > > + cond_resched(); > > } while_for_each_ftrace_rec(); > > } > > >