From: Dinh Nguyen <dinguyen@kernel.org>
To: stable@vger.kernel.org
Cc: dinguyen@kernel.org, gregkh@linuxfoundation.org,
sashal@kernel.org,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Philipp Zabel <p.zabel@pengutronix.de>
Subject: [PATCHv2 for v4.19-stable 6/6] reset: remove remaining WARN_ON() in <linux/reset.h>
Date: Tue, 4 Dec 2018 09:34:48 -0600 [thread overview]
Message-ID: <20181204153448.6189-7-dinguyen@kernel.org> (raw)
In-Reply-To: <20181204153448.6189-1-dinguyen@kernel.org>
From: Masahiro Yamada <yamada.masahiro@socionext.com>
commit bb6c7768385b200063a14d6615cc1246c3d00760 upstream.
Commit bb475230b8e5 ("reset: make optional functions really optional")
gave a new meaning to _get_optional variants.
The differentiation by WARN_ON() is not needed any more. We already
have inconsistency about this; (devm_)reset_control_get_exclusive()
has WARN_ON() check, but of_reset_control_get_exclusive() does not.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
include/linux/reset.h | 6 ------
1 file changed, 6 deletions(-)
diff --git a/include/linux/reset.h b/include/linux/reset.h
index 61a0dda3f981..7e99690dbc81 100644
--- a/include/linux/reset.h
+++ b/include/linux/reset.h
@@ -107,9 +107,6 @@ static inline int device_reset_optional(struct device *dev)
static inline struct reset_control *
__must_check reset_control_get_exclusive(struct device *dev, const char *id)
{
-#ifndef CONFIG_RESET_CONTROLLER
- WARN_ON(1);
-#endif
return __reset_control_get(dev, id, 0, false, false);
}
@@ -255,9 +252,6 @@ static inline struct reset_control *
__must_check devm_reset_control_get_exclusive(struct device *dev,
const char *id)
{
-#ifndef CONFIG_RESET_CONTROLLER
- WARN_ON(1);
-#endif
return __devm_reset_control_get(dev, id, 0, false, false);
}
--
2.17.1
next prev parent reply other threads:[~2018-12-04 15:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 15:34 [PATCHv2 for v4.19-stable 0/6] reset: make optional functions Dinh Nguyen
2018-12-04 15:34 ` [PATCHv2 for v4.19-stable 1/6] reset: make optional functions really optional Dinh Nguyen
2018-12-04 15:34 ` [PATCHv2 for v4.19-stable 2/6] reset: core: fix reset_control_put Dinh Nguyen
2018-12-04 15:34 ` [PATCHv2 for v4.19-stable 3/6] reset: fix optional reset_control_get stubs to return NULL Dinh Nguyen
2018-12-04 15:34 ` [PATCHv2 for v4.19-stable 4/6] reset: add exported __reset_control_get, return NULL if optional Dinh Nguyen
2018-12-04 15:34 ` [PATCHv2 for v4.19-stable 5/6] reset: make device_reset_optional() really optional Dinh Nguyen
2018-12-04 15:34 ` Dinh Nguyen [this message]
2018-12-04 15:45 ` [PATCHv2 for v4.19-stable 0/6] reset: make optional functions Greg KH
2018-12-04 15:45 ` Greg KH
2018-12-04 17:27 ` Dinh Nguyen
2018-12-06 11:01 ` Greg KH
2018-12-06 15:17 ` Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204153448.6189-7-dinguyen@kernel.org \
--to=dinguyen@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=p.zabel@pengutronix.de \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.