From: Segher Boessenkool <segher@kernel.crashing.org>
To: Joel Stanley <joel@jms.id.au>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linuxppc-dev@lists.ozlabs.org, Alan Modra <amodra@gmail.com>
Subject: Re: [PATCH v2 2/3] powerpc: Discard dynsym section for !PPC32
Date: Tue, 4 Dec 2018 11:40:33 -0600 [thread overview]
Message-ID: <20181204174032.GG3803@gate.crashing.org> (raw)
In-Reply-To: <20181204005429.32681-3-joel@jms.id.au>
On Tue, Dec 04, 2018 at 11:24:28AM +1030, Joel Stanley wrote:
> Alan Modra <amodra@gmail.com> explains:
>
> > Likely you could discard .interp > and .dynstr too, and .dynsym when
> > !CONFIG_PPC32.
>
> Discarding of interp and dynstr happened in a previous patch. The dynsym
> cleanup was a bit less straightforward, so it gets it's own patch.
> diff --git a/arch/powerpc/kernel/vmlinux.lds.S b/arch/powerpc/kernel/vmlinux.lds.S
> index 6570209b0671..2c93a420f456 100644
> --- a/arch/powerpc/kernel/vmlinux.lds.S
> +++ b/arch/powerpc/kernel/vmlinux.lds.S
> @@ -266,14 +266,13 @@ SECTIONS
> }
> #ifdef CONFIG_RELOCATABLE
> . = ALIGN(8);
> +#ifdef CONFIG_PPC32
> .dynsym : AT(ADDR(.dynsym) - LOAD_OFFSET)
> {
> -#ifdef CONFIG_PPC32
> __dynamic_symtab = .;
> -#endif
> *(.dynsym)
> }
> - .dynstr : AT(ADDR(.dynstr) - LOAD_OFFSET) { *(.dynstr) }
So this last line belongs in the previous patch then, right?
Segher
next prev parent reply other threads:[~2018-12-04 17:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 0:54 [PATCH v2 0/3] powerpc: Add to linker script discards Joel Stanley
2018-12-04 0:54 ` [PATCH v2 1/3] powerpc: Discard more sections in linker script Joel Stanley
2018-12-04 0:54 ` [PATCH v2 2/3] powerpc: Discard dynsym section for !PPC32 Joel Stanley
2018-12-04 17:40 ` Segher Boessenkool [this message]
2018-12-10 21:50 ` Joel Stanley
2018-12-04 0:54 ` [PATCH v2 3/3] powerpc: Discard .branch_lt section Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204174032.GG3803@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=amodra@gmail.com \
--cc=joel@jms.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.