From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH] nvme-core: small cleanups
Date: Tue, 4 Dec 2018 14:27:51 -0800 [thread overview]
Message-ID: <20181204222751.GA18078@infradead.org> (raw)
In-Reply-To: <20181129171804.5241-1-chaitanya.kulkarni@wdc.com>
> c.identify.nsid = cpu_to_le32(nsid);
> @@ -1565,10 +1569,7 @@ static int nvme_revalidate_disk(struct gendisk *disk)
> }
>
> id = nvme_identify_ns(ctrl, ns->head->ns_id);
> - if (!id)
> - return -ENODEV;
> -
> - if (id->ncap == 0) {
> + if (!id || id->ncap == 0) {
This now moves to kfree id which wasn't even allocated.
I think we can just drop the rest of the patch as well, it isn't
really worth the churn.
prev parent reply other threads:[~2018-12-04 22:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 17:18 [PATCH] nvme-core: small cleanups Chaitanya Kulkarni
2018-12-03 10:13 ` Johannes Thumshirn
2018-12-03 22:26 ` Chaitanya Kulkarni
2018-12-03 22:42 ` Bart Van Assche
2018-12-04 0:33 ` Sagi Grimberg
2018-12-04 22:26 ` Christoph Hellwig
2018-12-04 22:37 ` Keith Busch
2018-12-05 2:33 ` Bart Van Assche
2018-12-04 22:27 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204222751.GA18078@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.