All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Marek Vasut <marek.vasut@gmail.com>
Cc: devicetree@vger.kernel.org,
	Marek Vasut <marek.vasut+renesas@gmail.com>,
	Eugeniu Rosca <erosca@de.adit-jv.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Marc Kleine-Budde <mkl@pengutronix.de>,
	Simon Horman <horms+renesas@verge.net.au>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: can: rcar_canfd: document r8a77965 support
Date: Tue, 4 Dec 2018 16:56:03 -0600	[thread overview]
Message-ID: <20181204225603.GA16478@bogus> (raw)
In-Reply-To: <20181118173201.4645-1-marek.vasut+renesas@gmail.com>

On Sun, Nov 18, 2018 at 06:32:00PM +0100, Marek Vasut wrote:
> Document the support for rcar_canfd on R8A77965 SoC devices.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Eugeniu Rosca <erosca@de.adit-jv.com>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Marc Kleine-Budde <mkl@pengutronix.de>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Simon Horman <horms+renesas@verge.net.au>
> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Cc: linux-renesas-soc@vger.kernel.org
> ---
>  .../devicetree/bindings/net/can/rcar_canfd.txt      | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/can/rcar_canfd.txt b/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
> index ac71daa46195..4720e916fbdd 100644
> --- a/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
> +++ b/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
> @@ -6,6 +6,7 @@ Required properties:
>    - "renesas,rcar-gen3-canfd" for R-Car Gen3 compatible controller.
>    - "renesas,r8a7795-canfd" for R8A7795 (R-Car H3) compatible controller.
>    - "renesas,r8a7796-canfd" for R8A7796 (R-Car M3-W) compatible controller.
> +  - "renesas,r8a77965-canfd" for R8A77965 (R-Car M3-N) compatible controller.
>    - "renesas,r8a77970-canfd" for R8A77970 (R-Car V3M) compatible controller.
>    - "renesas,r8a77980-canfd" for R8A77980 (R-Car V3H) compatible controller.
>  
> @@ -26,12 +27,12 @@ The name of the child nodes are "channel0" and "channel1" respectively. Each
>  child node supports the "status" property only, which is used to
>  enable/disable the respective channel.
>  
> -Required properties for "renesas,r8a7795-canfd" and "renesas,r8a7796-canfd"
> -compatible:
> -In R8A7795 and R8A7796 SoCs, canfd clock is a div6 clock and can be used by both
> -CAN and CAN FD controller at the same time. It needs to be scaled to maximum
> -frequency if any of these controllers use it. This is done using the below
> -properties:
> +Required properties for "renesas,r8a7795-canfd", "renesas,r8a7796-canfd" and
> +"renesas,r8a77965-canfd" compatible:
> +In R8A7795, R8A7796 and R8A77965 SoCs, canfd clock is a div6 clock and can

Do we have to list the SoCs twice so that the paragraph has to be 
reformatted every time? Just the compatibles above should be enough.

> +be used by both CAN and CAN FD controller at the same time. It needs to be
> +scaled to maximum frequency if any of these controllers use it. This is done
> +using the below properties:
>  
>  - assigned-clocks: phandle of canfd clock.
>  - assigned-clock-rates: maximum frequency of this clock.
> -- 
> 2.18.0
> 

  parent reply	other threads:[~2018-12-04 22:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-18 17:32 [PATCH 1/2] dt-bindings: can: rcar_canfd: document r8a77965 support Marek Vasut
2018-11-18 17:32 ` [PATCH 2/2] dt-bindings: can: rcar_canfd: document r8a77990 support Marek Vasut
2018-11-21 10:20   ` Simon Horman
2019-02-16 14:00     ` Marek Vasut
2018-11-18 23:18 ` [PATCH 1/2] dt-bindings: can: rcar_canfd: document r8a77965 support Wolfram Sang
2018-11-18 23:21   ` Marek Vasut
2018-11-19  8:43   ` Geert Uytterhoeven
2018-11-19  9:40     ` Geert Uytterhoeven
2018-11-19 10:41   ` Simon Horman
2018-11-19 10:53     ` Wolfram Sang
2018-11-21 10:20       ` Simon Horman
2018-12-04 22:56 ` Rob Herring [this message]
2018-12-04 23:44   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181204225603.GA16478@bogus \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=erosca@de.adit-jv.com \
    --cc=geert+renesas@glider.be \
    --cc=horms+renesas@verge.net.au \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=marek.vasut+renesas@gmail.com \
    --cc=marek.vasut@gmail.com \
    --cc=mkl@pengutronix.de \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.