From: Andrea Parri <andrea.parri@amarulasolutions.com>
To: Roman Penyaev <rpenyaev@suse.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 1/1] epoll: use rwlock in order to reduce ep_poll_callback() contention
Date: Wed, 5 Dec 2018 00:59:07 +0100 [thread overview]
Message-ID: <20181204235907.GA5388@andrea> (raw)
In-Reply-To: <83edf06ce9db540495b53527eca3248c@suse.de>
Hi Roman,
On Tue, Dec 04, 2018 at 12:50:58PM +0100, Roman Penyaev wrote:
> On 2018-12-03 18:34, Linus Torvalds wrote:
> > This also ends up making the memory ordering of "xchg()" very very
> > important. Yes, we've documented it as being an ordering op, but I'm
> > not sure we've relied on it this directly before.
>
> Seems exit_mm() does exactly the same, the following chunk:
>
> up_read(&mm->mmap_sem);
>
> self.task = current;
> self.next = xchg(&core_state->dumper.next, &self);
>
>
> At least code pattern looks similar.
Maybe add a comment on top of (your) xchg() to note/justify these memory
ordering requirements? As Paul said: "if there are races, this would
help force them to happen" (and simplify the review, this/future).
Andrea
next prev parent reply other threads:[~2018-12-04 23:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 11:02 [RFC PATCH 1/1] epoll: use rwlock in order to reduce ep_poll_callback() contention Roman Penyaev
2018-12-03 17:34 ` Linus Torvalds
2018-12-04 11:50 ` Roman Penyaev
2018-12-04 23:59 ` Andrea Parri [this message]
2018-12-05 11:25 ` Roman Penyaev
2018-12-04 17:23 ` Jason Baron
2018-12-04 19:02 ` Paul E. McKenney
2018-12-05 11:22 ` Roman Penyaev
2018-12-05 11:16 ` Roman Penyaev
2018-12-05 16:38 ` Jason Baron
2018-12-05 20:11 ` Roman Penyaev
2018-12-06 1:54 ` Davidlohr Bueso
2018-12-06 3:08 ` Davidlohr Bueso
2018-12-06 10:27 ` Roman Penyaev
2018-12-06 4:04 ` Davidlohr Bueso
2018-12-06 10:25 ` Roman Penyaev
2018-12-05 23:46 ` Eric Wong
2018-12-06 10:52 ` Roman Penyaev
2018-12-06 20:35 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204235907.GA5388@andrea \
--to=andrea.parri@amarulasolutions.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rpenyaev@suse.de \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.