From: Shawn Guo <shawnguo@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, cphealy@gmail.com
Subject: Re: [PATCH] ARM: dts: vf610-zii-scu4-aib: Add HI8435 support
Date: Wed, 5 Dec 2018 11:40:31 +0800 [thread overview]
Message-ID: <20181205034029.GJ3987@dragon> (raw)
In-Reply-To: <1543504220-10870-1-git-send-email-festevam@gmail.com>
On Thu, Nov 29, 2018 at 01:10:20PM -0200, Fabio Estevam wrote:
> On the vf610-zii-scu4-aib board there is a hi8435 ( 32-channel
> discrete-to-digital SPI sensor device) in the DSPI0 bus.
>
> Add support for it.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> arch/arm/boot/dts/vf610-zii-scu4-aib.dts | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm/boot/dts/vf610-zii-scu4-aib.dts b/arch/arm/boot/dts/vf610-zii-scu4-aib.dts
> index 52bac14..a1fd49e 100644
> --- a/arch/arm/boot/dts/vf610-zii-scu4-aib.dts
> +++ b/arch/arm/boot/dts/vf610-zii-scu4-aib.dts
> @@ -397,6 +397,20 @@
> };
> };
>
> +&dspi0 {
> + pinctrl-0 = <&pinctrl_dspi0>;
> + pinctrl-names = "default";
> + status = "okay";
> + bus-num = <0>;
We usually put 'status' at the bottom of property list.
> +
> + hi8435@5 {
Can we have a generic name for the device?
Shawn
> + compatible = "holt,hi8435";
> + reg = <5>;
> + gpios = <&gpio5 3 GPIO_ACTIVE_HIGH>;
> + spi-max-frequency = <1000000>;
> + };
> +};
> +
> &dspi1 {
> bus-num = <1>;
> pinctrl-names = "default";
> --
> 2.7.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2018-12-05 3:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 15:10 [PATCH] ARM: dts: vf610-zii-scu4-aib: Add HI8435 support Fabio Estevam
2018-12-02 19:22 ` Chris Healy
2018-12-05 3:40 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181205034029.GJ3987@dragon \
--to=shawnguo@kernel.org \
--cc=cphealy@gmail.com \
--cc=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.