From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 3/3] fs/common.mk: make sure that static devices from packages are created
Date: Wed, 5 Dec 2018 08:53:11 +0100 [thread overview]
Message-ID: <20181205085311.6603a2b0@windsurf> (raw)
In-Reply-To: <606d6e8b-873c-2bb1-e3fb-861df79d819c@mind.be>
Hello,
On Tue, 4 Dec 2018 22:05:19 +0100, Arnout Vandecappelle wrote:
> > diff --git a/fs/common.mk b/fs/common.mk
> > index 077ce8903e..a560417c6c 100644
> > --- a/fs/common.mk
> > +++ b/fs/common.mk
> > @@ -61,10 +61,10 @@ endif
> > $(call PRINTF,$(PACKAGES_PERMISSIONS_TABLE)) > $(ROOTFS_FULL_DEVICES_TABLE)
> > ifneq ($(ROOTFS_DEVICE_TABLES),)
> > cat $(ROOTFS_DEVICE_TABLES) >> $(ROOTFS_FULL_DEVICES_TABLE)
> > +endif
> > ifeq ($(BR2_ROOTFS_DEVICE_CREATION_STATIC),y)
> > $(call PRINTF,$(PACKAGES_DEVICES_TABLE)) >> $(ROOTFS_FULL_DEVICES_TABLE)
> > endif
>
> This is still conflicting with the purpose of patch 2/3: the package device
> tables are still overriding the user-specified global device table.
Fair point. Should we do:
$(call PRINTF,$(PACKAGES_PERMISSIONS_TABLE)) > $(ROOTFS_FULL_DEVICES_TABLE)
ifeq ($(BR2_ROOTFS_DEVICE_CREATION_STATIC),y)
$(call PRINTF,$(PACKAGES_DEVICES_TABLE)) >> $(ROOTFS_FULL_DEVICES_TABLE)
endif
ifneq ($(ROOTFS_DEVICE_TABLES),)
cat $(ROOTFS_DEVICE_TABLES) >> $(ROOTFS_FULL_DEVICES_TABLE)
endif
instead ?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-12-05 7:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 21:05 [Buildroot] [PATCH v4 0/3] Misc fs/common.mk improvements Thomas Petazzoni
2018-12-03 21:05 ` [Buildroot] [PATCH v4 1/3] fs/common.mk: rename FULL_DEVICE_TABLE to ROOTFS_FULL_DEVICES_TABLE Thomas Petazzoni
2018-12-03 21:18 ` Yann E. MORIN
2018-12-03 21:05 ` [Buildroot] [PATCH v4 2/3] fs/common.mk: allow user provided permissions to override packages permissions Thomas Petazzoni
2018-12-03 21:05 ` [Buildroot] [PATCH v4 3/3] fs/common.mk: make sure that static devices from packages are created Thomas Petazzoni
2018-12-04 21:05 ` Arnout Vandecappelle
2018-12-05 7:53 ` Thomas Petazzoni [this message]
2018-12-05 9:18 ` Arnout Vandecappelle
2018-12-04 20:59 ` [Buildroot] [PATCH v4 0/3] Misc fs/common.mk improvements Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181205085311.6603a2b0@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.