From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, linux-kernel@vger.kernel.org, jolsa@kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] perf vendor events intel: Fix Load_Miss_Real_Latency on SKL/SKX
Date: Wed, 5 Dec 2018 11:21:40 +0100 [thread overview]
Message-ID: <20181205102140.GC2950@krava> (raw)
In-Reply-To: <20181120050635.4215-1-andi@firstfloor.org>
On Mon, Nov 19, 2018 at 09:06:35PM -0800, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> Fix incorrect event names for the Load_Miss_Real_Latency metric for
> Skylake and Skylake Server.
>
> Fixes https://github.com/andikleen/pmu-tools/issues/158
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
>
> Before:
>
> % perf stat -M Load_Miss_Real_Latency true
> event syntax error: '..ss.pending,mem_load_retired.l1_miss_ps,mem_load_retired.fb_hit_ps}:W'
> \___ parser error
>
> Usage: perf stat [<options>] [<command>]
>
> -M, --metrics <metric/metric group list>
> monitor specified metrics or metric groups (separated by ,)
>
> After:
>
> % perf stat -M Load_Miss_Real_Latency true
>
> Performance counter stats for 'true':
>
> 279,204 l1d_pend_miss.pending # 14.0 Load_Miss_Real_Latency
> 4,784 mem_load_uops_retired.l1_miss
> 15,188 mem_load_uops_retired.hit_lfb
>
> 0.000899640 seconds time elapsed
>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
> tools/perf/pmu-events/arch/x86/skylake/skl-metrics.json | 2 +-
> tools/perf/pmu-events/arch/x86/skylakex/skx-metrics.json | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/pmu-events/arch/x86/skylake/skl-metrics.json b/tools/perf/pmu-events/arch/x86/skylake/skl-metrics.json
> index 36c903faed0b..71e9737f4614 100644
> --- a/tools/perf/pmu-events/arch/x86/skylake/skl-metrics.json
> +++ b/tools/perf/pmu-events/arch/x86/skylake/skl-metrics.json
> @@ -73,7 +73,7 @@
> },
> {
> "BriefDescription": "Actual Average Latency for L1 data-cache miss demand loads",
> - "MetricExpr": "L1D_PEND_MISS.PENDING / ( MEM_LOAD_RETIRED.L1_MISS_PS + MEM_LOAD_RETIRED.FB_HIT_PS )",
> + "MetricExpr": "L1D_PEND_MISS.PENDING / ( MEM_LOAD_RETIRED.L1_MISS + MEM_LOAD_RETIRED.FB_HIT )",
> "MetricGroup": "Memory_Bound;Memory_Lat",
> "MetricName": "Load_Miss_Real_Latency"
> },
> diff --git a/tools/perf/pmu-events/arch/x86/skylakex/skx-metrics.json b/tools/perf/pmu-events/arch/x86/skylakex/skx-metrics.json
> index 36c903faed0b..71e9737f4614 100644
> --- a/tools/perf/pmu-events/arch/x86/skylakex/skx-metrics.json
> +++ b/tools/perf/pmu-events/arch/x86/skylakex/skx-metrics.json
> @@ -73,7 +73,7 @@
> },
> {
> "BriefDescription": "Actual Average Latency for L1 data-cache miss demand loads",
> - "MetricExpr": "L1D_PEND_MISS.PENDING / ( MEM_LOAD_RETIRED.L1_MISS_PS + MEM_LOAD_RETIRED.FB_HIT_PS )",
> + "MetricExpr": "L1D_PEND_MISS.PENDING / ( MEM_LOAD_RETIRED.L1_MISS + MEM_LOAD_RETIRED.FB_HIT )",
> "MetricGroup": "Memory_Bound;Memory_Lat",
> "MetricName": "Load_Miss_Real_Latency"
> },
> --
> 2.17.2
>
next prev parent reply other threads:[~2018-12-05 10:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 5:06 [PATCH] perf vendor events intel: Fix Load_Miss_Real_Latency on SKL/SKX Andi Kleen
2018-12-05 10:21 ` Jiri Olsa [this message]
2018-12-06 16:59 ` Arnaldo Carvalho de Melo
2018-12-14 20:58 ` [tip:perf/core] " tip-bot for Andi Kleen
2018-12-18 14:25 ` tip-bot for Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181205102140.GC2950@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.