From: Cornelia Huck <cohuck@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Eric Blake <eblake@redhat.com>,
qemu-devel@nongnu.org, Tony Krowiak <akrowiak@linux.ibm.com>,
qemu-riscv@nongnu.org, Pierre Morel <pmorel@linux.ibm.com>,
Viktor Prutyanov <viktor.prutyanov@phystech.edu>,
Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
Richard Henderson <rth@twiddle.net>,
Palmer Dabbelt <palmer@sifive.com>,
Alex Williamson <alex.williamson@redhat.com>,
Yuval Shaia <yuval.shaia@oracle.com>,
Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, Michael Clark <mjc@sifive.com>,
Alistair Francis <Alistair.Francis@wdc.com>,
Sagar Karandikar <sagark@eecs.berkeley.edu>,
Paolo Bonzini <pbonzini@redhat.com>,
Stefan Berger <stefanb@linux.ibm.com>,
Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-riscv] [Qemu-devel] [PATCH] Clean up includes
Date: Wed, 5 Dec 2018 11:45:47 +0100 [thread overview]
Message-ID: <20181205114547.6d1f2c2d.cohuck@redhat.com> (raw)
In-Reply-To: <874lbs2y8e.fsf@dusky.pond.sub.org>
On Wed, 05 Dec 2018 09:07:13 +0100
Markus Armbruster <armbru@redhat.com> wrote:
> > On 12/4/18 11:25 AM, Markus Armbruster wrote:
> >> Clean up includes so that osdep.h is included first and headers
> >> which it implies are not included manually.
> >>
> >> This commit was created with scripts/clean-includes, with the changes
> >> to the following files manually reverted:
(...)
> >> target/s390x/gen-features.c
(..)
> target/s390x/gen-features.c is a standalone program that is compiled in
> a way that breaks when we include osdep.h. If that's fixable, fixing it
> would be nice. Aside: not sure I'd have written this in C.
Yes, that file is a bit of an oddball. Might make sense to add a
comment there that it is standalone, so you can find that out without
looking at the Makefile. I don't think rewriting this to something else
is worth the effort.
next prev parent reply other threads:[~2018-12-05 13:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 17:25 [Qemu-riscv] [PATCH] Clean up includes Markus Armbruster
2018-12-04 17:46 ` [Qemu-riscv] [Qemu-devel] " Eric Blake
2018-12-05 8:07 ` Markus Armbruster
2018-12-05 10:45 ` Cornelia Huck [this message]
2018-12-04 18:43 ` [Qemu-riscv] " Eduardo Habkost
2018-12-05 9:15 ` [Qemu-riscv] [qemu-s390x] " Halil Pasic
2018-12-05 9:51 ` [Qemu-riscv] " Yuval Shaia
2018-12-05 10:47 ` Viktor Prutyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181205114547.6d1f2c2d.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=Alistair.Francis@wdc.com \
--cc=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=mjc@sifive.com \
--cc=palmer@sifive.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=pmorel@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=sagark@eecs.berkeley.edu \
--cc=stefanb@linux.ibm.com \
--cc=viktor.prutyanov@phystech.edu \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.