Re: [PATCH net-next RFC 2/7] devlink: Add port param get command

[Jiri Pirko <jiri@resnulli.us>]

Wed, Dec 05, 2018 at 06:56:55AM CET, vasundhara-v.volam@broadcom.com wrote:
>Add port param get command which gets data per parameter.
>It also has option to dump the parameters data per port.
>
>Cc: Jiri Pirko <jiri@mellanox.com>
>Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
>---
> include/uapi/linux/devlink.h |   2 +
> net/core/devlink.c           | 102 ++++++++++++++++++++++++++++++++++++++++---
> 2 files changed, 97 insertions(+), 7 deletions(-)
>
>diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h
>index 6e52d36..f96e052 100644
>--- a/include/uapi/linux/devlink.h
>+++ b/include/uapi/linux/devlink.h
>@@ -83,6 +83,8 @@ enum devlink_command {
> 	DEVLINK_CMD_PARAM_NEW,
> 	DEVLINK_CMD_PARAM_DEL,
> 
>+	DEVLINK_CMD_PORT_PARAM_GET,	/* can dump */

You need to add this to the end, otherwise you would break uapi.


>+
> 	DEVLINK_CMD_REGION_GET,
> 	DEVLINK_CMD_REGION_SET,
> 	DEVLINK_CMD_REGION_NEW,

[...]

The rest of the patch looks fine.