Re: [GIT PULL FOR v4.21] Rockchip VPU JPEG encoder driver

[Mauro Carvalho Chehab <mchehab+samsung@kernel.org>]

Em Wed, 5 Dec 2018 16:34:04 -0200
Mauro Carvalho Chehab <mchehab+samsung@kernel.org> escreveu:

> Em Wed, 5 Dec 2018 17:29:38 +0100
> Hans Verkuil <hverkuil@xs4all.nl> escreveu:
> 
> > Note regarding the first 'Revert' patch: that is this patch:
> > 
> > https://patchwork.linuxtv.org/patch/52869/
> > 
> > It is currently pending for 4.20 as a fix, but since it is not merged upstream
> > yet, our master branch still has those old bindings.
> > 
> > I decided to first apply the Revert patch, then add the new patch on top.
> > 
> > Regards,
> > 
> > 	Hans
> > 
> > The following changes since commit da2c94c8f9739e4099ea3cfefc208fc721b22a9c:
> > 
> >   media: v4l2: async: remove locking when initializing async notifier (2018-12-05 06:51:28 -0500)
> > 
> > are available in the Git repository at:
> > 
> >   git://linuxtv.org/hverkuil/media_tree.git tags/br-rkjpeg2
> > 
> > for you to fetch changes up to 7f608cfd52c08e7d84bd38438e330c26263eddcb:
> > 
> >   media: add Rockchip VPU JPEG encoder driver (2018-12-05 17:18:46 +0100)
> > 
> > ----------------------------------------------------------------
> > Tag branch
> > 
> > ----------------------------------------------------------------
> > Ezequiel Garcia (3):
> >       Revert "media: dt-bindings: Document the Rockchip VPU bindings"
> >       media: dt-bindings: Document the Rockchip VPU bindings
> >       media: add Rockchip VPU JPEG encoder driver  
> 
> Checkpatch produces a few warnings:
> 
> # CHECK: Alignment should match open parenthesis
> # #385: FILE: drivers/staging/media/rockchip/vpu/rk3288_vpu_hw_jpeg_enc.c:109:
> # +	rk3288_vpu_jpeg_enc_set_qtable(vpu,
> # +		rockchip_vpu_jpeg_get_qtable(&jpeg_ctx, 0),
> # 
> # CHECK: Alignment should match open parenthesis
> # #1124: FILE: drivers/staging/media/rockchip/vpu/rk3399_vpu_hw_jpeg_enc.c:140:
> # +	rk3399_vpu_jpeg_enc_set_qtable(vpu,
> # +			rockchip_vpu_jpeg_get_qtable(&jpeg_ctx, 0),
> # 
> # WARNING: DT compatible string "rockchip,rk3399-vpu" appears un-documented -- check ./Documentation/devicetree/bindings/
> # #2359: FILE: drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c:326:
> # +	{ .compatible = "rockchip,rk3399-vpu", .data = &rk3399_vpu_variant, },
> # 
> # WARNING: DT compatible string "rockchip,rk3288-vpu" appears un-documented -- check ./Documentation/devicetree/bindings/
> # #2360: FILE: drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c:327:
> # +	{ .compatible = "rockchip,rk3288-vpu", .data = &rk3288_vpu_variant, },
> # 
> # CHECK: Unnecessary parentheses around 'formats[i].codec_mode != RK_VPU_MODE_NONE'
> # #2721: FILE: drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c:145:
> # +		if (bitstream == (formats[i].codec_mode != RK_VPU_MODE_NONE))
> # 
> # total: 0 errors, 2 warnings, 3 checks, 3469 lines checked
> 
> The more weird ones are the ones related to the DT bindings.

Hmm... those were my fault.

/me needs caffeine

> 
> Regards,
> Mauro
> 
> Thanks,
> Mauro



Thanks,
Mauro