From: Michael Straube <straube.linux@gmail.com>
To: gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Michael Straube <straube.linux@gmail.com>
Subject: [PATCH v2 10/12] staging: rtl8188eu: replace if else with ternary operator
Date: Wed, 5 Dec 2018 19:30:58 +0100 [thread overview]
Message-ID: <20181205183100.16828-10-straube.linux@gmail.com> (raw)
In-Reply-To: <20181205183100.16828-1-straube.linux@gmail.com>
Replace if else with a single call and ternary operator to
slightly reduce object file size. Also clears a checkpatch
warning: WARNING: Statements should start on a tabstop
Suggested-by: Joe Perches <joe@perches.com>
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c b/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
index 7af3dd910c93..9a20faad96c9 100644
--- a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
+++ b/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
@@ -1440,10 +1440,9 @@ void update_wireless_mode(struct adapter *padapter)
rtw_hal_set_hwreg(padapter, HW_VAR_RESP_SIFS, (u8 *)&SIFS_Timer);
- if (pmlmeext->cur_wireless_mode & WIRELESS_11B)
- update_mgnt_tx_rate(padapter, IEEE80211_CCK_RATE_1MB);
- else
- update_mgnt_tx_rate(padapter, IEEE80211_OFDM_RATE_6MB);
+ update_mgnt_tx_rate(padapter,
+ pmlmeext->cur_wireless_mode & WIRELESS_11B ?
+ IEEE80211_CCK_RATE_1MB : IEEE80211_OFDM_RATE_6MB);
}
void update_bmc_sta_support_rate(struct adapter *padapter, u32 mac_id)
--
2.19.2
next prev parent reply other threads:[~2018-12-05 18:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 18:30 [PATCH v2 01/12] staging: rtl8188eu: refactor cckrates_included() Michael Straube
2018-12-05 18:30 ` [PATCH v2 02/12] staging: rtl8188eu: refactor cckratesonly_included() Michael Straube
2018-12-05 18:30 ` [PATCH v2 03/12] staging: rtl8188eu: simplify array initializations Michael Straube
2018-12-05 18:30 ` [PATCH v2 04/12] staging: rtl8188eu: remove unnecessary parentheses in rtw_wlan_util.c Michael Straube
2018-12-05 18:30 ` [PATCH v2 05/12] staging: rtl8188eu: cleanup declarations " Michael Straube
2018-12-05 18:30 ` [PATCH v2 06/12] staging: rtl8188eu: cleanup block comment " Michael Straube
2018-12-05 18:30 ` [PATCH v2 07/12] staging: rtl8188eu: cleanup long lines " Michael Straube
2018-12-05 18:30 ` [PATCH v2 08/12] staging: rtl8188eu: add spaces around operators " Michael Straube
2018-12-05 18:30 ` [PATCH v2 09/12] staging: rtl8188eu: write out multiplying in wifirate2_ratetbl_inx() Michael Straube
2018-12-05 18:30 ` Michael Straube [this message]
2018-12-05 18:30 ` [PATCH v2 11/12] staging: rtl8188eu: rename struct field Wifi_Error_Status Michael Straube
2018-12-05 18:31 ` [PATCH v2 12/12] staging: rtl8188eu: remove unused code in rtw_cmd.c Michael Straube
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181205183100.16828-10-straube.linux@gmail.com \
--to=straube.linux@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.