All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: devicetree@vger.kernel.org, "Dave Gerlach" <d-gerlach@ti.com>,
	Keerthy <j-keerthy@ti.com>, "Tero Kristo" <t-kristo@ti.com>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] ARM: dts: am437x: Move l4 child devices to probe them with ti-sysc
Date: Wed, 5 Dec 2018 15:02:42 -0800	[thread overview]
Message-ID: <20181205230242.GH6707@atomide.com> (raw)
In-Reply-To: <20181205190019.GG6707@atomide.com>

* Tony Lindgren <tony@atomide.com> [181205 19:00]:
> I think we're missing the top level ranges for mcasp l3 port
> and the translation goes wrong there, I'll fix it hopefully
> today.

Below is a fix for am473x that works for me as tested with
am473x-sk-evm. Care to test please?

I'll send also a similar fix for am335x separately. And
then for dra7. Looks like for dra7 we're also missing the
mcasp optional clocks too.

Regards,

Tony

8< ------------
>From tony Mon Sep 17 00:00:00 2001
From: Tony Lindgren <tony@atomide.com>
Date: Wed, 5 Dec 2018 14:08:21 -0800
Subject: [PATCH] ARM: dts: Add missing ranges for am437x mcasp l3 ports

We need to add mcasp l3 port ranges for mcasp to use a correct l3
data port address for dma.

Fixes: d95adfd45853 ("ARM: dts: am437x: Move l4 child devices to
probe them with ti-sysc")
Reported-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 arch/arm/boot/dts/am437x-l4.dtsi | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/am437x-l4.dtsi b/arch/arm/boot/dts/am437x-l4.dtsi
--- a/arch/arm/boot/dts/am437x-l4.dtsi
+++ b/arch/arm/boot/dts/am437x-l4.dtsi
@@ -613,7 +613,9 @@
 	ranges = <0x00000000 0x48000000 0x100000>,	/* segment 0 */
 		 <0x00100000 0x48100000 0x100000>,	/* segment 1 */
 		 <0x00200000 0x48200000 0x100000>,	/* segment 2 */
-		 <0x00300000 0x48300000 0x100000>;	/* segment 3 */
+		 <0x00300000 0x48300000 0x100000>,	/* segment 3 */
+		 <0x46000000 0x46000000 0x400000>,	/* l3 data port */
+		 <0x46400000 0x46400000 0x400000>;	/* l3 data port */
 
 	segment@0 {					/* 0x48000000 */
 		compatible = "simple-bus";
@@ -664,7 +666,9 @@
 			 <0x00034000 0x00034000 0x001000>,	/* ap 80 */
 			 <0x00035000 0x00035000 0x001000>,	/* ap 81 */
 			 <0x00036000 0x00036000 0x001000>,	/* ap 84 */
-			 <0x00037000 0x00037000 0x001000>;	/* ap 85 */
+			 <0x00037000 0x00037000 0x001000>,	/* ap 85 */
+			 <0x46000000 0x46000000 0x400000>,	/* l3 data port */
+			 <0x46400000 0x46400000 0x400000>;	/* l3 data port */
 
 		target-module@8000 {			/* 0x48008000, ap 6 10.0 */
 			compatible = "ti,sysc";
@@ -826,7 +830,8 @@
 			clock-names = "fck";
 			#address-cells = <1>;
 			#size-cells = <1>;
-			ranges = <0x0 0x38000 0x2000>;
+			ranges = <0x0 0x38000 0x2000>,
+				 <0x46000000 0x46000000 0x400000>;
 
 			mcasp0: mcasp@0 {
 				compatible = "ti,am33xx-mcasp-audio";
@@ -857,7 +862,8 @@
 			clock-names = "fck";
 			#address-cells = <1>;
 			#size-cells = <1>;
-			ranges = <0x0 0x3c000 0x2000>;
+			ranges = <0x0 0x3c000 0x2000>,
+				 <0x46400000 0x46400000 0x400000>;
 
 			mcasp1: mcasp@0 {
 				compatible = "ti,am33xx-mcasp-audio";
-- 
2.19.2

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: devicetree@vger.kernel.org, "Dave Gerlach" <d-gerlach@ti.com>,
	Keerthy <j-keerthy@ti.com>, "Tero Kristo" <t-kristo@ti.com>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] ARM: dts: am437x: Move l4 child devices to probe them with ti-sysc
Date: Wed, 5 Dec 2018 15:02:42 -0800	[thread overview]
Message-ID: <20181205230242.GH6707@atomide.com> (raw)
In-Reply-To: <20181205190019.GG6707@atomide.com>

* Tony Lindgren <tony@atomide.com> [181205 19:00]:
> I think we're missing the top level ranges for mcasp l3 port
> and the translation goes wrong there, I'll fix it hopefully
> today.

Below is a fix for am473x that works for me as tested with
am473x-sk-evm. Care to test please?

I'll send also a similar fix for am335x separately. And
then for dra7. Looks like for dra7 we're also missing the
mcasp optional clocks too.

Regards,

Tony

8< ------------
From tony Mon Sep 17 00:00:00 2001
From: Tony Lindgren <tony@atomide.com>
Date: Wed, 5 Dec 2018 14:08:21 -0800
Subject: [PATCH] ARM: dts: Add missing ranges for am437x mcasp l3 ports

We need to add mcasp l3 port ranges for mcasp to use a correct l3
data port address for dma.

Fixes: d95adfd45853 ("ARM: dts: am437x: Move l4 child devices to
probe them with ti-sysc")
Reported-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 arch/arm/boot/dts/am437x-l4.dtsi | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/am437x-l4.dtsi b/arch/arm/boot/dts/am437x-l4.dtsi
--- a/arch/arm/boot/dts/am437x-l4.dtsi
+++ b/arch/arm/boot/dts/am437x-l4.dtsi
@@ -613,7 +613,9 @@
 	ranges = <0x00000000 0x48000000 0x100000>,	/* segment 0 */
 		 <0x00100000 0x48100000 0x100000>,	/* segment 1 */
 		 <0x00200000 0x48200000 0x100000>,	/* segment 2 */
-		 <0x00300000 0x48300000 0x100000>;	/* segment 3 */
+		 <0x00300000 0x48300000 0x100000>,	/* segment 3 */
+		 <0x46000000 0x46000000 0x400000>,	/* l3 data port */
+		 <0x46400000 0x46400000 0x400000>;	/* l3 data port */
 
 	segment@0 {					/* 0x48000000 */
 		compatible = "simple-bus";
@@ -664,7 +666,9 @@
 			 <0x00034000 0x00034000 0x001000>,	/* ap 80 */
 			 <0x00035000 0x00035000 0x001000>,	/* ap 81 */
 			 <0x00036000 0x00036000 0x001000>,	/* ap 84 */
-			 <0x00037000 0x00037000 0x001000>;	/* ap 85 */
+			 <0x00037000 0x00037000 0x001000>,	/* ap 85 */
+			 <0x46000000 0x46000000 0x400000>,	/* l3 data port */
+			 <0x46400000 0x46400000 0x400000>;	/* l3 data port */
 
 		target-module@8000 {			/* 0x48008000, ap 6 10.0 */
 			compatible = "ti,sysc";
@@ -826,7 +830,8 @@
 			clock-names = "fck";
 			#address-cells = <1>;
 			#size-cells = <1>;
-			ranges = <0x0 0x38000 0x2000>;
+			ranges = <0x0 0x38000 0x2000>,
+				 <0x46000000 0x46000000 0x400000>;
 
 			mcasp0: mcasp@0 {
 				compatible = "ti,am33xx-mcasp-audio";
@@ -857,7 +862,8 @@
 			clock-names = "fck";
 			#address-cells = <1>;
 			#size-cells = <1>;
-			ranges = <0x0 0x3c000 0x2000>;
+			ranges = <0x0 0x3c000 0x2000>,
+				 <0x46400000 0x46400000 0x400000>;
 
 			mcasp1: mcasp@0 {
 				compatible = "ti,am33xx-mcasp-audio";
-- 
2.19.2

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2018-12-05 23:02 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-25  0:05 [PATCH 0/4] Update am437x and am335x dts to probe with ti-sysc Tony Lindgren
2018-09-25  0:05 ` Tony Lindgren
2018-09-25  0:05 ` [PATCH 1/4] ARM: dts: am437x: Add l4 interconnect hierarchy and ti-sysc data Tony Lindgren
2018-09-25  0:05   ` Tony Lindgren
2018-09-25  0:05 ` [PATCH 2/4] ARM: dts: am437x: Move l4 child devices to probe them with ti-sysc Tony Lindgren
2018-09-25  0:05   ` Tony Lindgren
2018-12-04 12:23   ` Peter Ujfalusi
2018-12-04 12:23     ` Peter Ujfalusi
2018-12-04 18:11     ` Tony Lindgren
2018-12-04 18:11       ` Tony Lindgren
2018-12-04 23:18       ` Tony Lindgren
2018-12-04 23:18         ` Tony Lindgren
2018-12-05  6:14         ` Peter Ujfalusi
2018-12-05 19:00           ` Tony Lindgren
2018-12-05 19:00             ` Tony Lindgren
2018-12-05 23:02             ` Tony Lindgren [this message]
2018-12-05 23:02               ` Tony Lindgren
2018-12-07 12:46               ` Peter Ujfalusi
2018-09-25  0:05 ` [PATCH 3/4] ARM: dts: am335x: Add l4 interconnect hierarchy and ti-sysc data Tony Lindgren
2018-09-25  0:05   ` Tony Lindgren
2018-09-27 14:56   ` Tony Lindgren
2018-09-27 14:56     ` Tony Lindgren
2018-09-25  0:05 ` [PATCH 4/4] ARM: dts: am335x: Move l4 child devices to probe them with ti-sysc Tony Lindgren
2018-09-25  0:05   ` Tony Lindgren
2018-11-27 13:03   ` Peter Ujfalusi
2018-11-27 13:03     ` Peter Ujfalusi
2018-11-27 16:16     ` Tony Lindgren
2018-11-27 16:16       ` Tony Lindgren
2018-11-28 12:52       ` Peter Ujfalusi
2018-11-28 12:52         ` Peter Ujfalusi
2018-11-29 19:07         ` Tony Lindgren
2018-11-29 19:07           ` Tony Lindgren
2018-09-25  5:14 ` [PATCH 0/4] Update am437x and am335x dts to probe " Keerthy
2018-09-25  5:14   ` Keerthy
2018-09-25 14:40   ` Tony Lindgren
2018-09-25 14:40     ` Tony Lindgren
2018-09-25 17:55     ` Tony Lindgren
2018-09-25 17:55       ` Tony Lindgren
2018-09-25 21:16       ` Grygorii Strashko
2018-09-25 21:16         ` Grygorii Strashko
2018-09-26  4:08       ` Keerthy
2018-09-26  4:08         ` Keerthy
2018-09-26 15:59         ` Tony Lindgren
2018-09-26 15:59           ` Tony Lindgren
2018-09-26 16:23           ` Tony Lindgren
2018-09-26 16:23             ` Tony Lindgren
2018-09-26 21:36             ` Grygorii Strashko
2018-09-26 21:36               ` Grygorii Strashko
2018-09-26 23:31               ` Tony Lindgren
2018-09-26 23:31                 ` Tony Lindgren
2018-09-27  4:55                 ` Keerthy
2018-09-27  4:55                   ` Keerthy
2018-09-27 14:53                   ` Tony Lindgren
2018-09-27 14:53                     ` Tony Lindgren
2018-09-27 21:43                     ` Tony Lindgren
2018-09-27 21:43                       ` Tony Lindgren
2018-10-01 16:32                   ` Tony Lindgren
2018-10-01 16:32                     ` Tony Lindgren
2018-10-04  4:29                     ` Keerthy
2018-10-04  4:29                       ` Keerthy
2018-10-04 14:23                       ` Tony Lindgren
2018-10-04 14:23                         ` Tony Lindgren
2018-09-27 19:11                 ` Grygorii Strashko
2018-09-27 19:11                   ` Grygorii Strashko
2018-09-27 19:38                   ` Tony Lindgren
2018-09-27 19:38                     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181205230242.GH6707@atomide.com \
    --to=tony@atomide.com \
    --cc=bcousson@baylibre.com \
    --cc=d-gerlach@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=j-keerthy@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@ti.com \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.