All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: kernel@pengutronix.de, kbuild test robot <lkp@intel.com>,
	linux-arm-kernel@lists.infradead.org, kbuild-all@01.org
Subject: Re: [shawnguo:imx/soc 2/2] arch/arm/Kconfig.debug:1445: syntax error
Date: Thu, 6 Dec 2018 21:57:08 +0800	[thread overview]
Message-ID: <20181206135706.GA12929@dragon> (raw)
In-Reply-To: <20181206130617.c3x353tgwyxjszc4@pengutronix.de>

On Thu, Dec 06, 2018 at 02:06:17PM +0100, Uwe Kleine-König wrote:
> Hello,
> 
> On Thu, Dec 06, 2018 at 08:44:30PM +0800, kbuild test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git imx/soc
> > head:   911dccedb00e5b45cf2d0fafc21aba233b58e115
> > commit: 911dccedb00e5b45cf2d0fafc21aba233b58e115 [2/2] ARM: debug-imx: only define DEBUG_IMX_UART_PORT if needed
> > config: arm-hackkit_defconfig
> > compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
> > reproduce:
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         git checkout 911dccedb00e5b45cf2d0fafc21aba233b58e115
> >         GCC_VERSION=7.2.0 make.cross ARCH=arm  hackkit_defconfig
> >         GCC_VERSION=7.2.0 make.cross ARCH=arm 
> > 
> > All errors (new ones prefixed by >>):
> > 
> > >> arch/arm/Kconfig.debug:1445: syntax error
> > >> arch/arm/Kconfig.debug:1444: invalid option
> 
> hmm, I was sure I tested that, but I can confirm it fails for me, too.
> 
> The obvious fix is:
> 
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index 3f057593db01..c253a4e79868 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -1441,18 +1441,18 @@ config DEBUG_OMAP2PLUS_UART
>  
>  config DEBUG_IMX_UART_PORT
>  	int "i.MX Debug UART Port Selection"
> -	depends on DEBUG_IMX1_UART ||
> -		   DEBUG_IMX25_UART ||
> -		   DEBUG_IMX21_IMX27_UART ||
> -		   DEBUG_IMX31_UART ||
> -		   DEBUG_IMX35_UART ||
> -		   DEBUG_IMX50_UART ||
> -		   DEBUG_IMX51_UART ||
> -		   DEBUG_IMX53_UART ||
> -		   DEBUG_IMX6Q_UART ||
> -		   DEBUG_IMX6SL_UART ||
> -		   DEBUG_IMX6SX_UART ||
> -		   DEBUG_IMX6UL_UART ||
> +	depends on DEBUG_IMX1_UART || \
> +		   DEBUG_IMX25_UART || \
> +		   DEBUG_IMX21_IMX27_UART || \
> +		   DEBUG_IMX31_UART || \
> +		   DEBUG_IMX35_UART || \
> +		   DEBUG_IMX50_UART || \
> +		   DEBUG_IMX51_UART || \
> +		   DEBUG_IMX53_UART || \
> +		   DEBUG_IMX6Q_UART || \
> +		   DEBUG_IMX6SL_UART || \
> +		   DEBUG_IMX6SX_UART || \
> +		   DEBUG_IMX6UL_UART || \
>  		   DEBUG_IMX7D_UART
>  	default 1
>  	help
> 
> @Shawn: Can you squash this into the original commit?

Done.

Shawn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      reply	other threads:[~2018-12-06 13:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-06 12:44 [shawnguo:imx/soc 2/2] arch/arm/Kconfig.debug:1445: syntax error kbuild test robot
2018-12-06 13:06 ` Uwe Kleine-König
2018-12-06 13:57   ` Shawn Guo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181206135706.GA12929@dragon \
    --to=shawnguo@kernel.org \
    --cc=kbuild-all@01.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=lkp@intel.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.