From: Joerg Roedel <joro@8bytes.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: iommu@lists.linux-foundation.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, Joerg Roedel <jroedel@suse.de>
Subject: Re: [PATCH 2/4] iommu: Consolitate ->add/remove_device() calls
Date: Thu, 6 Dec 2018 16:47:09 +0100 [thread overview]
Message-ID: <20181206154709.GJ16835@8bytes.org> (raw)
In-Reply-To: <3ca13757-edf8-95cb-6316-73d202f97dbf@arm.com>
On Wed, Dec 05, 2018 at 06:20:50PM +0000, Robin Murphy wrote:
> Is there any good reason to let .add_device/.remove_device be optional
> still? Everyone's implemented them for a while now, and on a practical level
> I don't really see how else we could expect devices to be taken in and out
> of their appropriate groups correctly.
There is probably no reason anymore to keep add_device/remove_device
option. I'll check the users and remove the pointer checks if possible.
Regards,
Joerg
next prev parent reply other threads:[~2018-12-06 15:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 14:36 [PATCH 0/4] Consolitate iommu_ops->add/remove_device() calls Joerg Roedel
2018-12-05 14:36 ` [PATCH 1/4] iommu/sysfs: Rename iommu_release_device() Joerg Roedel
2018-12-05 14:36 ` [PATCH 2/4] iommu: Consolitate ->add/remove_device() calls Joerg Roedel
[not found] ` <20181205143646.4876-3-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2018-12-05 14:54 ` Christoph Hellwig
2018-12-05 14:54 ` Christoph Hellwig
2018-12-05 15:14 ` Joerg Roedel
2018-12-05 18:20 ` Robin Murphy
2018-12-06 15:47 ` Joerg Roedel [this message]
2018-12-05 14:36 ` [PATCH 3/4] iommu/of: Don't call iommu_ops->add_device directly Joerg Roedel
2018-12-05 18:49 ` Robin Murphy
2018-12-06 16:19 ` Joerg Roedel
[not found] ` <20181205143646.4876-1-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2018-12-05 14:36 ` [PATCH 4/4] ACPI/IORT: " Joerg Roedel
2018-12-05 14:36 ` Joerg Roedel
-- strict thread matches above, loose matches on Subject: below --
2018-12-11 15:05 [PATCH 0/4 v2] Consolidate iommu_ops->add/remove_device() calls Joerg Roedel
2018-12-11 15:05 ` [PATCH 2/4] iommu: Consolitate ->add/remove_device() calls Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181206154709.GJ16835@8bytes.org \
--to=joro@8bytes.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jroedel@suse.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.