From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bryan O'Donoghue <pure.logic@nexus-software.ie>
Cc: Sicilia Cristian <sicilia.cristian@gmail.com>,
devel@driverdev.osuosl.org, Alex Elder <elder@kernel.org>,
Johan Hovold <johan@kernel.org>,
linux-kernel@vger.kernel.org, greybus-dev@lists.linaro.org
Subject: Re: [PATCH 2/2] staging: greybus: Added space between string concatenated
Date: Thu, 6 Dec 2018 17:23:40 +0100 [thread overview]
Message-ID: <20181206162340.GA12032@kroah.com> (raw)
In-Reply-To: <131a4c41-2c5f-a660-5190-52ce5d59e532@nexus-software.ie>
On Thu, Dec 06, 2018 at 04:14:53PM +0000, Bryan O'Donoghue wrote:
> On 06/12/2018 15:05, Greg Kroah-Hartman wrote:
> > On Thu, Dec 06, 2018 at 09:43:46AM +0000, Bryan O'Donoghue wrote:
> > > On 05/12/2018 21:00, Sicilia Cristian wrote:
> > > > It doesn't change the result string
> > >
> > > So why do it then ?
> >
> > Because it is easier to read this way and odds are checkpatch is
> > happier.
>
> Fine.
>
> Sicilia could you please amend your commit.
>
> 'This patch fixes the checkpatch error "CHECK: Concatenated strings should
> use spaces between elements"'
>
> and then feel free to add my
>
> Acked-by: Bryan O'Donoghue <pure.logic@nexus-software.ie>
It's already in my tree, no need to ammend it, sorry :)
greg k-h
next prev parent reply other threads:[~2018-12-06 16:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 20:58 [PATCH 0/2] staging: greybus: Fix parameters alignment and strings concatenation Cristian Sicilia
2018-12-04 20:58 ` [PATCH 1/2] staging: greybus: Align function call parameters to parenthesis Cristian Sicilia
2018-12-05 8:46 ` Greg Kroah-Hartman
2018-12-05 21:09 ` Sicilia Cristian
2018-12-04 20:58 ` [PATCH 2/2] staging: greybus: Added space between string concatenated Cristian Sicilia
2018-12-05 10:12 ` Bryan O'Donoghue
2018-12-05 21:00 ` Sicilia Cristian
2018-12-06 9:43 ` Bryan O'Donoghue
2018-12-06 15:05 ` Greg Kroah-Hartman
2018-12-06 16:14 ` Bryan O'Donoghue
2018-12-06 16:23 ` Greg Kroah-Hartman [this message]
2018-12-06 16:24 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181206162340.GA12032@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=elder@kernel.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pure.logic@nexus-software.ie \
--cc=sicilia.cristian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.