From: Ingo Molnar <mingo@kernel.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Sean Christopherson <sean.j.christopherson@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Rik van Riel <riel@surriel.com>,
Yu-cheng Yu <yu-cheng.yu@intel.com>
Subject: Re: [PATCH] x86/mm/fault: Streamline the fault error_code decoder some more
Date: Thu, 6 Dec 2018 18:36:21 +0100 [thread overview]
Message-ID: <20181206173621.GA31884@gmail.com> (raw)
In-Reply-To: <EF7E7857-B4DF-4C14-85F5-114B03D5295D@amacapital.net>
* Andy Lutomirski <luto@amacapital.net> wrote:
> That’s why I suggested “read,” in lowercase, for reads. Other than
> that, most of the unset bits are uninteresting. An OOPS is so likely to
> be a kernel fault that it’s barely worth mentioning, and I even added a
> whole separate diagnostic for user oopses. Similarly, I don’t think we
> need to remind the reader that an oops wasn’t an SGX error or that it
> wasn’t a PK error. So I think my idea highlights the interesting bits
> and avoids distraction from the uninteresting bits.
Ok - all good points.
Thanks,
Ingo
next prev parent reply other threads:[~2018-12-06 17:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 16:36 [PATCH] x86/fault: Print "SUPERVISOR" and "READ" when decoding #PF oops Sean Christopherson
2018-12-05 19:27 ` Randy Dunlap
2018-12-05 19:35 ` Linus Torvalds
2018-12-06 7:34 ` [PATCH] x86/mm/fault: Streamline the fault error_code decoder some more Ingo Molnar
2018-12-06 15:53 ` Sean Christopherson
2018-12-06 16:23 ` Ingo Molnar
2018-12-06 16:39 ` Andy Lutomirski
2018-12-06 16:47 ` Ingo Molnar
2018-12-06 17:05 ` Andy Lutomirski
2018-12-06 17:36 ` Ingo Molnar [this message]
2018-12-06 18:15 ` Linus Torvalds
2018-12-06 19:06 ` Andy Lutomirski
2018-12-06 20:24 ` Linus Torvalds
2018-12-06 20:28 ` Andy Lutomirski
2018-12-06 20:39 ` Linus Torvalds
2018-12-07 18:44 ` [PATCH] x86/fault: Decode and print #PF oops in human readable form Sean Christopherson
2018-12-07 18:52 ` Linus Torvalds
2018-12-07 19:18 ` Sean Christopherson
2018-12-07 19:52 ` [PATCH v2] " Sean Christopherson
2018-12-07 20:46 ` Linus Torvalds
2018-12-07 22:06 ` Sean Christopherson
2018-12-07 22:14 ` Linus Torvalds
2018-12-07 23:57 ` Andy Lutomirski
2018-12-10 16:04 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181206173621.GA31884@gmail.com \
--to=mingo@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=riel@surriel.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
--cc=yu-cheng.yu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.