From: Pavel Machek <pavel@ucw.cz>
To: David Miller <davem@davemloft.net>
Cc: andrew@lunn.ch, vivien.didelot@savoirfairelinux.com,
netdev@vger.kernel.org, f.fainelli@gmail.com,
buytenh@marvell.com, buytenh@wantstofly.org, nico@marvell.com
Subject: Re: mv88e6060: Turn e6060 driver into e6065 driver
Date: Thu, 6 Dec 2018 21:35:22 +0100 [thread overview]
Message-ID: <20181206203522.GA26718@amd> (raw)
In-Reply-To: <20181206.122333.646375739770814733.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 757 bytes --]
On Thu 2018-12-06 12:23:33, David Miller wrote:
> From: Pavel Machek <pavel@ucw.cz>
> Date: Thu, 6 Dec 2018 14:03:45 +0100
>
> > @@ -79,7 +82,7 @@ static enum dsa_tag_protocol mv88e6060_get_tag_protocol(struct dsa_switch *ds,
> > {
> > //return DSA_TAG_PROTO_QCA;
> > //return DSA_TAG_PROTO_TRAILER;
>
> These C++ style comments are not in any of my tree(s).
>
> Your patch submission really needs to shape up if you want your patches
> to be considered seriously.
This one should have been "RFD". It has way more serious problems then
this, as changelog tried to explain.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-12-06 20:35 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 19:51 DSA support for Marvell 88e6065 switch Pavel Machek
2018-11-15 20:26 ` Andrew Lunn
2018-11-18 18:07 ` Pavel Machek
2018-11-18 18:20 ` Andrew Lunn
2018-11-18 20:15 ` Pavel Machek
2018-11-19 3:25 ` Andrew Lunn
2018-11-22 13:21 ` Pavel Machek
2018-11-22 15:33 ` Lennert Buytenhek
2018-11-22 20:27 ` Pavel Machek
2018-12-03 1:42 ` Lennert Buytenhek
2018-12-05 20:46 ` Pavel Machek
2018-12-05 22:20 ` Florian Fainelli
2018-12-06 14:40 ` Pavel Machek
2019-01-29 22:57 ` mv88e6xxx -- DSA support for Marvell 88e6065 switch (and maybe 88e6060?) Pavel Machek
2019-01-29 23:12 ` Andrew Lunn
2019-01-29 23:21 ` Vivien Didelot
2018-12-06 13:00 ` Well supported DSA switches, support for Marvell 88e6065 switch Pavel Machek
2018-12-06 13:01 ` [PATCH] mv88e6060: Warn about errors Pavel Machek
2018-12-06 20:21 ` David Miller
2018-12-06 20:36 ` Pavel Machek
2018-12-06 13:02 ` [RFD] mv88e6060: Allow the driver to be probed from device tree Pavel Machek
2018-12-06 18:32 ` kbuild test robot
2018-12-15 8:41 ` kbuild test robot
2018-12-06 13:03 ` mv88e6060: Turn e6060 driver into e6065 driver Pavel Machek
2018-12-06 20:23 ` David Miller
2018-12-06 20:35 ` Pavel Machek [this message]
2018-12-06 13:05 ` [PATCH] dsa device tree bindings: fix typo and wrong example Pavel Machek
2018-12-06 13:28 ` Vokáč Michal
2019-01-07 18:49 ` Pavel Machek
2019-01-07 18:53 ` Florian Fainelli
2018-12-06 13:06 ` [RFC] tag_daddr: add tagging scheme used by Marvel 88e6065 switch Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181206203522.GA26718@amd \
--to=pavel@ucw.cz \
--cc=andrew@lunn.ch \
--cc=buytenh@marvell.com \
--cc=buytenh@wantstofly.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nico@marvell.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.