From: Bjorn Helgaas <helgaas@kernel.org>
To: Benjamin Young <youngcdev@gmail.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pcie: portdrv: Fix Unnecessary space before function pointer arguments
Date: Thu, 6 Dec 2018 14:44:07 -0600 [thread overview]
Message-ID: <20181206204407.GB247703@google.com> (raw)
In-Reply-To: <20181201160711.GA21373@ycd-dell-ltp>
On Sat, Dec 01, 2018 at 08:07:11AM -0800, Benjamin Young wrote:
> Made spacing more consistent in the code for function pointer
> declarations based on checkpatch.pl
>
> Signed-off-by: Benjamin Young <youngcdev@gmail.com>
Applied to pci/misc for v4.21, thanks!
I also made similar changes to include/linux/pci.h. For trivial changes
like this I like to fix similar issues in all of PCI at the same time.
> ---
> drivers/pci/pcie/portdrv.h | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/pci/pcie/portdrv.h b/drivers/pci/pcie/portdrv.h
> index e495f04..fbbf00b0 100644
> --- a/drivers/pci/pcie/portdrv.h
> +++ b/drivers/pci/pcie/portdrv.h
> @@ -71,19 +71,19 @@ static inline void *get_service_data(struct pcie_device *dev)
>
> struct pcie_port_service_driver {
> const char *name;
> - int (*probe) (struct pcie_device *dev);
> - void (*remove) (struct pcie_device *dev);
> - int (*suspend) (struct pcie_device *dev);
> - int (*resume_noirq) (struct pcie_device *dev);
> - int (*resume) (struct pcie_device *dev);
> - int (*runtime_suspend) (struct pcie_device *dev);
> - int (*runtime_resume) (struct pcie_device *dev);
> + int (*probe)(struct pcie_device *dev);
> + void (*remove)(struct pcie_device *dev);
> + int (*suspend)(struct pcie_device *dev);
> + int (*resume_noirq)(struct pcie_device *dev);
> + int (*resume)(struct pcie_device *dev);
> + int (*runtime_suspend)(struct pcie_device *dev);
> + int (*runtime_resume)(struct pcie_device *dev);
>
> /* Device driver may resume normal operations */
> void (*error_resume)(struct pci_dev *dev);
>
> /* Link Reset Capability - AER service driver specific */
> - pci_ers_result_t (*reset_link) (struct pci_dev *dev);
> + pci_ers_result_t (*reset_link)(struct pci_dev *dev);
>
> int port_type; /* Type of the port this driver can handle */
> u32 service; /* Port service this device represents */
> --
> 2.5.0
>
next prev parent reply other threads:[~2018-12-06 20:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-01 16:07 [PATCH] pcie: portdrv: Fix Unnecessary space before function pointer arguments Benjamin Young
2018-12-06 20:44 ` Bjorn Helgaas [this message]
2018-12-06 20:50 ` Benjamin Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181206204407.GB247703@google.com \
--to=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=youngcdev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.