All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 02/11] support/scripts/graph-depends: use proper rootpkg in remove_extra_deps()
Date: Thu, 6 Dec 2018 22:16:55 +0100	[thread overview]
Message-ID: <20181206221655.1cfbaa78@windsurf> (raw)
In-Reply-To: <8730ab5253daddf6c5aaed9b4cc058e446faa624.1543741464.git.yann.morin.1998@free.fr>

Hello,

On Sun,  2 Dec 2018 10:04:34 +0100, Yann E. MORIN wrote:
> From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> 
> The remove_extra_deps() function removes dependencies that we are not
> interested in seeing in the dependency graph. It does this for all
> packages, except the 'all' package, which on full dependency graphs is
> the root of the tree.
> 
> However, this doesn't take into account package-specific dependency
> graphs (i.e make <pkg>-graph-depends) where the root is not 'all', but
> '<pkg>'. Due to this, dependencies on "mandatory deps" were not
> visible at all, i.e the toolchain package (and its dependencies) and
> the skeleton package (and its dependencies) were not displayed in
> package-specific dependency graphs.
> 
> To fix this, we use the existing rootpkg variable instead of
> hardcoding 'all'.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
>  support/scripts/graph-depends | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-12-06 21:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-02  9:04 [Buildroot] [PATCH 00/11] support/graphs: fixup and speedup graph dependencies (branch yem/graphs-from-make-2) Yann E. MORIN
2018-12-02  9:04 ` [Buildroot] [PATCH 01/11] support/graph-depends: drop legacy target-exceptions Yann E. MORIN
2018-12-06 21:16   ` Thomas Petazzoni
2018-12-02  9:04 ` [Buildroot] [PATCH 02/11] support/scripts/graph-depends: use proper rootpkg in remove_extra_deps() Yann E. MORIN
2018-12-06 21:16   ` Thomas Petazzoni [this message]
2018-12-02  9:04 ` [Buildroot] [PATCH 03/11] support/scripts/graph-depends: introduce MANDATORY_DEPS array Yann E. MORIN
2018-12-06 21:17   ` Thomas Petazzoni
2018-12-02  9:04 ` [Buildroot] [PATCH 04/11] support/graph-depends: add option to exclude mandatory deps Yann E. MORIN
2018-12-02  9:04 ` [Buildroot] [PATCH 05/11] support/scripts/graph-depends: make sure mandatory deps are displayed Yann E. MORIN
2018-12-02  9:04 ` [Buildroot] [PATCH 06/11] support/graph-depends: also cut on host-skeleton Yann E. MORIN
2018-12-02  9:04 ` [Buildroot] [PATCH 07/11] support/graph-depends: also cut on host-tar Yann E. MORIN
2018-12-02  9:04 ` [Buildroot] [PATCH 08/11] support/graph-depends: also cut on host-gzip Yann E. MORIN
2018-12-02  9:04 ` [Buildroot] [PATCH 09/11] infra/pkg-generic: use pure Makefile-based recursive dependencies Yann E. MORIN
2018-12-02  9:04 ` [Buildroot] [PATCH 10/11] core: add make-based full-dependency list Yann E. MORIN
2018-12-02  9:04 ` [Buildroot] [PATCH 11/11] supprt/graph-depends: use the new make-based dependency tree Yann E. MORIN
2018-12-04  4:02   ` Matthew Weber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181206221655.1cfbaa78@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.