From: Christoph Hellwig <hch@lst.de>
To: Christoph Hellwig <hch@lst.de>,
"Clark, Rob" <robdclark@gmail.com>,
Dave Airlie <airlied@linux.ie>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Tomasz Figa <tfiga@chromium.org>,
Sean Paul <seanpaul@chromium.org>,
vivek.gautam@codeaurora.org,
freedreno <freedreno@lists.freedesktop.org>,
Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH v3 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*
Date: Fri, 7 Dec 2018 02:38:41 +0100 [thread overview]
Message-ID: <20181207013841.GA4530@lst.de> (raw)
In-Reply-To: <20181130094604.GV21184@phenom.ffwll.local>
On Fri, Nov 30, 2018 at 10:46:04AM +0100, Daniel Vetter wrote:
> > Being able to dip into CMA and maybe iommu coalescing if we want to
> > get fancy is indeed the only reason for this API. If we just wanted
> > to map pages we could already do that now with just a little bit
> > of boilerplate code (and quite a few drivers do - just adding this
> > new API will remove tons of code).
>
> Sounds like the future is very bright indeed \o/
So, I spent some time with this and instead of a new API I think
it makes sure we have DMA_ATTR_NON_CONSISTENT consistently available
and with well defined semantics, that is virt_to_page on the return
value works, it is contiguos and we can use dma_sync_single_for_cpu
and dma_sync_single_for_device for ownership tranfers.
Can you graphics folks check if this:
http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/dma-noncoherent-allocator
is something to work with? Especially to get rid of the horrible
dma_get_sgtable hacks?
next prev parent reply other threads:[~2018-12-07 1:38 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 14:03 [PATCH v3 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg* Vivek Gautam
2018-11-29 14:14 ` Christoph Hellwig
2018-11-29 14:25 ` Rob Clark
[not found] ` <CAF6AEGvsFbXGkC+=4oq1xXnoC2EVX2J0k-GqShefcek1=uw4Lw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-11-29 14:42 ` Rob Clark
2018-11-29 15:54 ` Christoph Hellwig
[not found] ` <20181129155418.GB26537-jcswGhMUV9g@public.gmane.org>
2018-11-29 18:48 ` Rob Clark
[not found] ` <CAF6AEGufdp5jRtUZ_+VRQg3ZXH36hNHvbWZQeJDArp8N5SZ3Lg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-11-29 19:40 ` Jordan Crouse
2018-11-29 19:57 ` Tomasz Figa
[not found] ` <CAAFQd5D139pNx9aEpO8745R4kfVYCBDyqyJNR_HDDXvKt7NZjw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-11-29 20:03 ` Robin Murphy
2018-11-30 0:23 ` Tomasz Figa
2018-12-01 2:05 ` Tomasz Figa
[not found] ` <CAAFQd5DMgGDPcK=4DktfC7T9O0MrU1VBqJqR+6VYpOh_DdEXUg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-12-01 11:46 ` Rob Clark
[not found] ` <CAF6AEGujyP78PjOMwTmdHcJKpsrgmRGage=pFniad98peMBrDw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-12-03 0:12 ` Tomasz Figa
2018-11-29 14:43 ` Daniel Vetter
2018-11-29 15:57 ` Christoph Hellwig
[not found] ` <20181129155758.GC26537-jcswGhMUV9g@public.gmane.org>
2018-11-29 16:28 ` Daniel Vetter
[not found] ` <20181129162807.GL21184-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2018-11-29 16:57 ` Christoph Hellwig
2018-11-29 17:09 ` Daniel Vetter
2018-11-29 17:24 ` Tomasz Figa
2018-11-29 18:35 ` Christoph Hellwig
[not found] ` <CAAFQd5A-Bh711VaNWhRJqcrofkBVCMFcNgqfztoyWJcUdhSu0Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-11-29 18:57 ` Rob Clark
2018-11-30 9:40 ` Daniel Vetter
2018-11-30 9:35 ` Daniel Vetter
2018-11-30 9:44 ` Christoph Hellwig
2018-11-29 18:33 ` Christoph Hellwig
[not found] ` <20181129183334.GB30281-jcswGhMUV9g@public.gmane.org>
2018-11-30 9:46 ` Daniel Vetter
2018-12-07 1:38 ` Christoph Hellwig [this message]
[not found] ` <20181207013841.GA4530-jcswGhMUV9g@public.gmane.org>
2018-12-07 14:29 ` Rob Clark
2018-11-29 17:33 ` Brian Starkey
[not found] ` <20181129173301.rye77slpy27regi5-cyTpl0DnfLAx1Goa8x4jbQH0AcctZ4a01BehtkLrGTY@public.gmane.org>
2018-11-29 18:35 ` Christoph Hellwig
2018-11-30 1:15 ` Rob Clark
2018-11-30 9:35 ` Christoph Hellwig
2018-11-29 15:53 ` Christoph Hellwig
[not found] ` <20181129155310.GA26537-jcswGhMUV9g@public.gmane.org>
2018-11-29 18:44 ` Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181207013841.GA4530@lst.de \
--to=hch@lst.de \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=robin.murphy@arm.com \
--cc=seanpaul@chromium.org \
--cc=tfiga@chromium.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.