From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by kanga.kvack.org (Postfix) with ESMTP id 255DE6B7F5B for ; Fri, 7 Dec 2018 02:53:25 -0500 (EST) Received: by mail-ed1-f69.google.com with SMTP id e12so1578401edd.16 for ; Thu, 06 Dec 2018 23:53:25 -0800 (PST) Received: from mx1.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id o14si1103467edq.447.2018.12.06.23.53.23 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Dec 2018 23:53:23 -0800 (PST) Date: Fri, 7 Dec 2018 08:53:22 +0100 From: Michal Hocko Subject: Re: [PATCH] mm/alloc: fallback to first node if the wanted node offline Message-ID: <20181207075322.GS1286@dhcp22.suse.cz> References: <20181205092148.GA1286@dhcp22.suse.cz> <186b1804-3b1e-340e-f73b-f3c7e69649f5@suse.cz> <20181206082806.GB1286@dhcp22.suse.cz> <20181206121152.GH1286@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Pingfan Liu Cc: Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Mike Rapoport , Bjorn Helgaas , Jonathan Cameron On Fri 07-12-18 10:56:51, Pingfan Liu wrote: [...] > In a short word, the fix method should consider about the two factors: > semantic of online-node and the effect on all archs I am pretty sure there is a lot of room for unification in this area. Nevertheless I strongly believe the bug should be fixed firs with the simplest way and all the cleanup should be done on top. Do I get it right that the diff worked for you and I can prepare a full patch? -- Michal Hocko SUSE Labs