From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] dl-wrapper: Fix urlencode option never being sent to backend
Date: Fri, 7 Dec 2018 18:35:22 +0100 [thread overview]
Message-ID: <20181207173522.GH2561@scaer> (raw)
In-Reply-To: <b97d7c67314b9312d4a79aa1a40ec4bd55ed61ff.camel@vitec.com>
Damien, All,
On 2018-12-07 12:41 +0000, Damien Th?bault spake thusly:
> The urlencode parameter is lost in dl-wrapper, because we try to get it
> from backend instead of backend_urlencode.
>
> We must get the urlencode information from backend_urlencode.
What is this trying to fix, actually? We have no download issue in the
autobuilders, as far as I can see... Do you have a test-case to share?
But true, this is incorrect, and was broken by commit 38de434123
(download: fix file:// BR2_PRIMARY_SITE (download cache)).
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> Signed-off-by: Damien Th?bault <damien.thebault@vitec.com>
> ---
> support/download/dl-wrapper | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/support/download/dl-wrapper b/support/download/dl-wrapper
> index bb70c98253..3315bd410e 100755
> --- a/support/download/dl-wrapper
> +++ b/support/download/dl-wrapper
> @@ -93,7 +93,7 @@ main() {
> esac
> uri=${uri#*+}
>
> - urlencode=${backend#*|}
> + urlencode=${backend_urlencode#*|}
> # urlencode must be "urlencode"
> [ "${urlencode}" != "urlencode" ] && urlencode=""
>
> --
> 2.19.1
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-12-07 17:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 12:41 [Buildroot] [PATCH] dl-wrapper: Fix urlencode option never being sent to backend Damien Thébault
2018-12-07 17:35 ` Yann E. MORIN [this message]
2018-12-10 8:03 ` Damien Thébault
2018-12-10 8:13 ` Thomas Petazzoni
2018-12-10 16:50 ` Yann E. MORIN
2018-12-09 16:18 ` Thomas Petazzoni
2018-12-16 19:46 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181207173522.GH2561@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.