From: Tony Lindgren <tony@atomide.com>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: "David Airlie" <airlied@linux.ie>,
"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
dri-devel@lists.freedesktop.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH] drm/omap: sharp ls037v7dw01: restore optional GPIOs
Date: Fri, 7 Dec 2018 13:39:40 -0800 [thread overview]
Message-ID: <20181207213940.GJ39861@atomide.com> (raw)
In-Reply-To: <E1gVNbW-00041H-Cm@rmk-PC.armlinux.org.uk>
* Russell King <rmk+kernel@armlinux.org.uk> [181207 21:24]:
> The binding document for this device says that all GPIOs are optional,
> but the driver fails to bind on OMAP3 LDP, reporting:
>
> panel-sharp-ls037v7dw01: probe of display failed with error -2
>
> Unfortunately, commit ca8c67dafdb7 ("fbdev: omap2: improve usage of
> gpiod API") removed the -ENOENT handling without converting the
> gpiod function to use the optional variant, causing all GPIOs to become
> mandatory.
>
> Since the LDP hard-wires some of the panel control signals, there are
> no GPIOs that could be specified in DT to satisfy this.
>
> Switch the driver to use the devm_gpiod_get_index_optional() rather
> than devm_gpiod_get_index() to conform to its binding documentation.
>
> Fixes: ca8c67dafdb7 ("fbdev: omap2: improve usage of gpiod API")
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Acked-by: Tony Lindgren <tony@atomide.com>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-12-07 21:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 21:24 [PATCH] drm/omap: sharp ls037v7dw01: restore optional GPIOs Russell King
2018-12-07 21:39 ` Tony Lindgren [this message]
2018-12-07 23:36 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181207213940.GJ39861@atomide.com \
--to=tony@atomide.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=tomi.valkeinen@ti.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.