All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Marek Vasut <marex@denx.de>
Cc: netdev@vger.kernel.org, f.fainelli@gmail.com,
	vivien.didelot@savoirfairelinux.com, Woojung.Huh@microchip.com,
	UNGLinuxDriver@microchip.com,
	"David S . Miller" <davem@davemloft.net>,
	Tristram Ha <Tristram.Ha@microchip.com>
Subject: Re: [PATCH V2] net: dsa: ksz: Add reset GPIO handling
Date: Fri, 7 Dec 2018 23:24:02 +0100	[thread overview]
Message-ID: <20181207222402.GA5844@lunn.ch> (raw)
In-Reply-To: <20181207215136.2808-1-marex@denx.de>

On Fri, Dec 07, 2018 at 10:51:36PM +0100, Marek Vasut wrote:
> Add code to handle optional reset GPIO in the KSZ switch driver. The switch
> has a reset GPIO line which can be controlled by the CPU, so make sure it is
> configured correctly in such setups.

Hi Marek

Please make this a patch series, not two individual patches.

And as David has already said, include a cover letter.

Otherwise, this looks O.K.

    Thanks
	Andrew

  reply	other threads:[~2018-12-07 22:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-07 21:51 [PATCH V2] net: dsa: ksz: Add reset GPIO handling Marek Vasut
2018-12-07 22:24 ` Andrew Lunn [this message]
2018-12-07 22:59   ` Marek Vasut
2018-12-07 23:46     ` David Miller
2018-12-08  4:21       ` Marek Vasut
2018-12-08 11:11     ` Andrew Lunn
2018-12-10 13:26       ` Marek Vasut
2018-12-10 14:37         ` Andrew Lunn
2018-12-12  0:39           ` Marek Vasut
2018-12-10 18:01         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181207222402.GA5844@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Tristram.Ha@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=Woojung.Huh@microchip.com \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=marex@denx.de \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.