All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <chris@printf.net>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: "Avri Altman" <Avri.Altman@wdc.com>,
	"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>,
	"Hans-Christian Noren Egtvedt" <egtvedt@samfundet.no>,
	"Clément Péron" <peron.clem@gmail.com>,
	"Michael Heimpold" <mhei@heimpold.de>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH mmc-utils] fix GCC7 build by refactoring trimming routines
Date: Sat, 8 Dec 2018 05:56:30 +0000	[thread overview]
Message-ID: <20181208055630.GB12686@void.printf.net> (raw)
In-Reply-To: <20181203142442.cfxrx3aqj6qacnjp@ninjato>

Hi everyone, I'm very sorry for the delay in responding to these patches
and the duplicated effort it caused.

On Mon, Dec 03, 2018 at 03:24:42PM +0100, Wolfram Sang wrote:
> Hi Avri, hi Chris,
> 
> > > I got a compile error with GCC7. When trimming white spaces from strings
> > > lsmmc uses strncpy with overlapping memory areas. This is not allowed.
> > > In addition, the implementation was not efficient with calling strlen
> > > and strncpy once per iteration. Refactor the code to be valid and more
> > > effective.
> > > 
> > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Thanks, I've applied this fix of Wolfram's to mmc-utils master.

> Thanks for the pointer. Chris, how do you feel with maintaining
> mmc-utils? Would you maybe be willing to share maintenance with someone?

Yep, that'd make sense.

-- 
Chris Ball   <http://printf.net/>

      reply	other threads:[~2018-12-08  6:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-03 13:19 [PATCH mmc-utils] fix GCC7 build by refactoring trimming routines Wolfram Sang
2018-12-03 14:02 ` Avri Altman
2018-12-03 14:24   ` Wolfram Sang
2018-12-08  5:56     ` Chris Ball [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181208055630.GB12686@void.printf.net \
    --to=chris@printf.net \
    --cc=Avri.Altman@wdc.com \
    --cc=egtvedt@samfundet.no \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=mhei@heimpold.de \
    --cc=peron.clem@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=wsa+renesas@sang-engineering.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.