From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Paweł Chmiel" <pawel.mikolaj.chmiel@gmail.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, xc-racer2@live.ca,
simon@lineageos.org
Subject: Re: [PATCH 3/8] Input: tm2-touchkey: Use predefined device name
Date: Sat, 8 Dec 2018 20:23:38 -0800 [thread overview]
Message-ID: <20181209042338.GC211094@dtor-ws> (raw)
In-Reply-To: <20181207105811.1831-4-pawel.mikolaj.chmiel@gmail.com>
On Fri, Dec 07, 2018 at 11:58:06AM +0100, Paweł Chmiel wrote:
> From: Jonathan Bakker <xc-racer2@live.ca>
>
> Purely a cosmetic fix, using the names defined earlier
If we decide to keep different names please fold into first patch.
>
> Signed-off-by: Jonathan Bakker <xc-racer2@live.ca>
> Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com>
> ---
> drivers/input/keyboard/tm2-touchkey.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/keyboard/tm2-touchkey.c b/drivers/input/keyboard/tm2-touchkey.c
> index 37a5ced24009..cc713b901bf2 100644
> --- a/drivers/input/keyboard/tm2-touchkey.c
> +++ b/drivers/input/keyboard/tm2-touchkey.c
> @@ -57,13 +57,13 @@ struct tm2_touchkey_data {
> };
>
> static struct touchkey_variant tm2_touchkey_variant = {
> - .name = "tm2-touchkey",
> + .name = TM2_TOUCHKEY_DEV_NAME,
> .keycode_reg = 0x03,
> .base_reg = 0x00,
> };
>
> static struct touchkey_variant midas_touchkey_variant = {
> - .name = "midas-touchkey",
> + .name = MIDAS_TOUCHKEY_DEV_NAME,
> .keycode_reg = 0x00,
> .base_reg = 0x00,
> };
> --
> 2.17.1
>
--
Dmitry
next prev parent reply other threads:[~2018-12-09 4:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 10:58 [PATCH 0/8] Input: tm2-touchkey: Add support for Aries and Midas Paweł Chmiel
2018-12-07 10:58 ` [PATCH 1/8] Input: tm2-touchkey: Add support for midas touchkey Paweł Chmiel
2018-12-09 4:22 ` Dmitry Torokhov
2018-12-07 10:58 ` [PATCH 2/8] Input: dt-bindings: " Paweł Chmiel
2018-12-20 17:09 ` Rob Herring
2018-12-20 17:09 ` Rob Herring
2018-12-07 10:58 ` [PATCH 3/8] Input: tm2-touchkey: Use predefined device name Paweł Chmiel
2018-12-09 4:23 ` Dmitry Torokhov [this message]
2018-12-07 10:58 ` [PATCH 4/8] Input: tm2-touchkey: Correct initial brightness Paweł Chmiel
2018-12-07 10:58 ` [PATCH 5/8] Input: tm2-touchkey: Allow specifying custom keycodes Paweł Chmiel
2018-12-07 10:58 ` [PATCH 6/8] Input: dt-bindings: tm2-touchkey: Document new keycodes property Paweł Chmiel
2018-12-09 4:57 ` Dmitry Torokhov
2018-12-07 10:58 ` [PATCH 7/8] Input: tm2-touchkey: Add support for aries touchkey variant Paweł Chmiel
2018-12-07 10:58 ` [PATCH 8/8] Input: dt-bindings: tm2-touchkey: Add support for aries touchkey Paweł Chmiel
2018-12-20 17:10 ` Rob Herring
2018-12-20 17:10 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181209042338.GC211094@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.mikolaj.chmiel@gmail.com \
--cc=robh+dt@kernel.org \
--cc=simon@lineageos.org \
--cc=xc-racer2@live.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.