From: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
To: git@vger.kernel.org
Cc: avarab@gmail.com
Subject: [RFC PATCH 2/2] grep: fallback to interpreter if JIT fails with pcre2
Date: Sun, 9 Dec 2018 15:00:24 -0800 [thread overview]
Message-ID: <20181209230024.43444-3-carenas@gmail.com> (raw)
In-Reply-To: <20181209230024.43444-1-carenas@gmail.com>
starting with 10.23, and as a side effect of the work for bug1749[1] (grep
-P crash with seLinux), pcre2grep was modified to ignore any errors from
pcre2_jit_compile so the interpreter could be used as a fallback
[1] https://bugs.exim.org/show_bug.cgi?id=1749
Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
---
grep.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/grep.c b/grep.c
index 5ccc0421a1..c751c8cc74 100644
--- a/grep.c
+++ b/grep.c
@@ -530,8 +530,11 @@ static void compile_pcre2_pattern(struct grep_pat *p, const struct grep_opt *opt
pcre2_config(PCRE2_CONFIG_JIT, &p->pcre2_jit_on);
if (p->pcre2_jit_on == 1) {
jitret = pcre2_jit_compile(p->pcre2_pattern, PCRE2_JIT_COMPLETE);
- if (jitret)
- die("Couldn't JIT the PCRE2 pattern '%s', got '%d'\n", p->pattern, jitret);
+ if (jitret) {
+ /* JIT failed so fallback to the interpreter */
+ p->pcre2_jit_on = 0;
+ return;
+ }
/*
* The pcre2_config(PCRE2_CONFIG_JIT, ...) call just
--
2.20.0
next prev parent reply other threads:[~2018-12-09 23:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-09 23:00 [RFC PATCH 0/2] fallback to interpreter if JIT fails with pcre Carlo Marcelo Arenas Belón
2018-12-09 23:00 ` [RFC PATCH 1/2] grep: fallback to interpreter if JIT fails with pcre1 Carlo Marcelo Arenas Belón
2018-12-09 23:51 ` Ævar Arnfjörð Bjarmason
2018-12-10 0:42 ` brian m. carlson
2018-12-10 1:25 ` Carlo Arenas
2018-12-10 6:42 ` Junio C Hamano
2018-12-10 8:24 ` Ævar Arnfjörð Bjarmason
2018-12-11 20:11 ` Carlo Arenas
2018-12-11 20:51 ` Ævar Arnfjörð Bjarmason
2018-12-10 6:54 ` Junio C Hamano
2018-12-10 6:48 ` Junio C Hamano
2018-12-09 23:00 ` Carlo Marcelo Arenas Belón [this message]
2018-12-10 7:00 ` [RFC PATCH 2/2] grep: fallback to interpreter if JIT fails with pcre2 Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181209230024.43444-3-carenas@gmail.com \
--to=carenas@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.