From: David Gibson <david@gibson.dropbear.id.au>
To: Leonardo Bras <leonardo@linux.vnet.ibm.com>
Cc: "Paul A. Clarke" <pc@us.ibm.com>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/1] Changes requirement for "vsubsbs" instruction
Date: Mon, 10 Dec 2018 13:40:36 +1100 [thread overview]
Message-ID: <20181210024036.GC4261@umbus.fritz.box> (raw)
In-Reply-To: <20181207171314.30769-1-leonardo@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1617 bytes --]
On Fri, Dec 07, 2018 at 03:13:14PM -0200, Leonardo Bras wrote:
> From: "Paul A. Clarke" <pc@us.ibm.com>
>
> Changes requirement for "vsubsbs" instruction, which has been supported
> since ISA 2.03. (Please see section 5.9.1.2 of ISA 2.03)
>
> Reported-by: Paul A. Clarke <pc@us.ibm.com>
> Signed-off-by: Paul A. Clarke <pc@us.ibm.com>
> Signed-off-by: Leonardo Bras <leonardo@linux.vnet.ibm.com>
Those instruction generating macros are super-confusing, but I think
this is right. vsubsbs has been there for ages with altivec, bcdtrunc
is new in ISA 3.0.
Applied to ppc-for-4.0.
> ---
> target/ppc/translate/vmx-ops.inc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/ppc/translate/vmx-ops.inc.c b/target/ppc/translate/vmx-ops.inc.c
> index 139f80cb24..84e05fb827 100644
> --- a/target/ppc/translate/vmx-ops.inc.c
> +++ b/target/ppc/translate/vmx-ops.inc.c
> @@ -143,7 +143,7 @@ GEN_VXFORM(vaddsws, 0, 14),
> GEN_VXFORM_DUAL(vsububs, bcdadd, 0, 24, PPC_ALTIVEC, PPC_NONE),
> GEN_VXFORM_DUAL(vsubuhs, bcdsub, 0, 25, PPC_ALTIVEC, PPC_NONE),
> GEN_VXFORM(vsubuws, 0, 26),
> -GEN_VXFORM_DUAL(vsubsbs, bcdtrunc, 0, 28, PPC_NONE, PPC2_ISA300),
> +GEN_VXFORM_DUAL(vsubsbs, bcdtrunc, 0, 28, PPC_ALTIVEC, PPC2_ISA300),
> GEN_VXFORM(vsubshs, 0, 29),
> GEN_VXFORM_DUAL(vsubsws, xpnd04_2, 0, 30, PPC_ALTIVEC, PPC_NONE),
> GEN_VXFORM_207(vadduqm, 0, 4),
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-12-10 2:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 17:13 [Qemu-devel] [PATCH 1/1] Changes requirement for "vsubsbs" instruction Leonardo Bras
2018-12-10 2:40 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210024036.GC4261@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=leonardo@linux.vnet.ibm.com \
--cc=pc@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.