From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH] drivers/base: use a worker for sysfs unbind Date: Mon, 10 Dec 2018 11:06:34 +0100 Message-ID: <20181210100634.GA8836@kroah.com> References: <20181210084653.7268-1-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id AFA526E3A3 for ; Mon, 10 Dec 2018 10:06:36 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181210084653.7268-1-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Daniel Vetter , LKML , DRI Development , "Rafael J. Wysocki" List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBEZWMgMTAsIDIwMTggYXQgMDk6NDY6NTNBTSArMDEwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBEcml2ZXJzIG1pZ2h0IHdhbnQgdG8gcmVtb3ZlIHNvbWUgc3lzZnMgZmlsZXMsIHdo aWNoIG5lZWRzIHRoZSBzYW1lCj4gbG9ja3MgYW5kIGVuZHMgdXAgYW5nZXJpbmcgbG9ja2RlcC4g UmVsZXZhbnQgc25pcHBldCBvZiB0aGUgc3RhY2sKPiB0cmFjZToKPiAKPiAgIGtlcm5mc19yZW1v dmVfYnlfbmFtZV9ucysweDNiLzB4ODAKPiAgIGJ1c19yZW1vdmVfZHJpdmVyKzB4OTIvMHhhMAo+ ICAgYWNwaV92aWRlb191bnJlZ2lzdGVyKzB4MjQvMHg0MAo+ICAgaTkxNV9kcml2ZXJfdW5sb2Fk KzB4NDIvMHgxMzAgW2k5MTVdCj4gICBpOTE1X3BjaV9yZW1vdmUrMHgxOS8weDMwIFtpOTE1XQo+ ICAgcGNpX2RldmljZV9yZW1vdmUrMHgzNi8weGIwCj4gICBkZXZpY2VfcmVsZWFzZV9kcml2ZXJf aW50ZXJuYWwrMHgxODUvMHgyNTAKPiAgIHVuYmluZF9zdG9yZSsweGFmLzB4MTgwCj4gICBrZXJu ZnNfZm9wX3dyaXRlKzB4MTA0LzB4MTkwCj4gCj4gSSd2ZSBzdHVtYmxlZCBvdmVyIHRoaXMgYmVj YXVzZSBzb21lIG5ldyBwYXRjaGVzIGJ5IFJhbSBjb25uZWN0IHRoZQo+IHNuZC1oZGEtaW50ZWwg dW5sb2FkICh3aGVyZSB3ZSBkbyB1c2Ugc3lzZnMgdW5iaW5kKSB3aXRoIHRoZSBsb2NraW5nCj4g Y2hhaW5zIGluIHRoZSBpOTE1IHVubG9hZCBjb2RlIChidXQgd2l0aG91dCBjcmVhdGluZyBhIG5l dyBsb29wKSwKPiB3aGljaCB1cHNldCBvdXIgQ0kuIEJ1dCB0aGUgYnVnIGlzIGFscmVhZHkgdGhl cmUgYW5kIGNhbiBiZSBlYXNpbHkKPiByZXByb2R1Y2VkIGJ5IHVuYmluZCBpOTE1IGRpcmVjdGx5 LgoKVGhpcyBpcyBvZGQsIHdoeSB3b3VsZG4ndCBhbnkgZHJpdmVyIGhpdCB0aGlzIGlzc3VlPyAg QW5kIHdoeSBub3cgc2luY2UKeW91IHNheSB0aGlzIGlzIHRyaWdnZXJhYmxlIHRvZGF5PwoKSSBr bm93IHNjc2kgd2FzIGRvaW5nIHNvbWUgc3RyYW5nZSB0aGluZ3MgbGlrZSB0cnlpbmcgdG8gcmVt b3ZlIHRoZQpkZXZpY2UgaXRzZWxmIGZyb20gYSBzeXNmcyBjYWxsYmFjayBvbiB0aGUgZGV2aWNl LCB3aGljaCByZXF1aXJlcyBpdCB0bwpqdXN0IGNhbGwgYSBkaWZmZXJlbnQga29iamVjdCBmdW5j dGlvbiBjcmVhdGVkIGp1c3QgZm9yIHRoYXQgdHlwZSBvZgp0aGluZy4gIFdvdWxkIHRoYXQgYWxz byBtYWtlIHNlbnNlIHRvIGRvIGhlcmUgaW5zdGVhZCBvZiB5b3VyIHdvcmtxdWV1ZT8KCnRoYW5r cywKCmdyZWcgay1oCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E590C04EB8 for ; Mon, 10 Dec 2018 10:06:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EE44220880 for ; Mon, 10 Dec 2018 10:06:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544436399; bh=faVDNK86VYlzOIfJDdA59imcMuuyQeR01dMI+p2GZyI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=g6NQNK0O+9N9skPiTmJx+m5yv5enlH7i6vGWs5Stx/mmCkz4skEnqpO5wMUm+Tf1D MedKfyaoNmKEVincfvhnxwLbeBbvjsbOGcYUzhbVpnRI8y4RHQ9q0gGJj2CbjSMZ4b mpIMOa86tF4Oeok75GGMhGMPRmSissI9UsjF5m40= DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE44220880 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726965AbeLJKGh (ORCPT ); Mon, 10 Dec 2018 05:06:37 -0500 Received: from mail.kernel.org ([198.145.29.99]:58386 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726622AbeLJKGh (ORCPT ); Mon, 10 Dec 2018 05:06:37 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0F88820821; Mon, 10 Dec 2018 10:06:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544436396; bh=faVDNK86VYlzOIfJDdA59imcMuuyQeR01dMI+p2GZyI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GC6bqOvASFge7pRIew0gTH82twietfN7xfUrKphtulpUpXNE4aSMMx/3HfQmSJNtB 7XYJ7irVkzu2QHlAuSn/dAIu7HJKaLJvCmBh5hwT6nMzQ/YB8EHoQonDPFEGTyiVjq Yzi4g3z2fmq528gne+0Uwm8DbKx8KYK8jsGLtYbc= Date: Mon, 10 Dec 2018 11:06:34 +0100 From: Greg Kroah-Hartman To: Daniel Vetter Cc: LKML , DRI Development , Ramalingam C , "Rafael J. Wysocki" , Daniel Vetter Subject: Re: [PATCH] drivers/base: use a worker for sysfs unbind Message-ID: <20181210100634.GA8836@kroah.com> References: <20181210084653.7268-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181210084653.7268-1-daniel.vetter@ffwll.ch> User-Agent: Mutt/1.11.1 (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 10, 2018 at 09:46:53AM +0100, Daniel Vetter wrote: > Drivers might want to remove some sysfs files, which needs the same > locks and ends up angering lockdep. Relevant snippet of the stack > trace: > > kernfs_remove_by_name_ns+0x3b/0x80 > bus_remove_driver+0x92/0xa0 > acpi_video_unregister+0x24/0x40 > i915_driver_unload+0x42/0x130 [i915] > i915_pci_remove+0x19/0x30 [i915] > pci_device_remove+0x36/0xb0 > device_release_driver_internal+0x185/0x250 > unbind_store+0xaf/0x180 > kernfs_fop_write+0x104/0x190 > > I've stumbled over this because some new patches by Ram connect the > snd-hda-intel unload (where we do use sysfs unbind) with the locking > chains in the i915 unload code (but without creating a new loop), > which upset our CI. But the bug is already there and can be easily > reproduced by unbind i915 directly. This is odd, why wouldn't any driver hit this issue? And why now since you say this is triggerable today? I know scsi was doing some strange things like trying to remove the device itself from a sysfs callback on the device, which requires it to just call a different kobject function created just for that type of thing. Would that also make sense to do here instead of your workqueue? thanks, greg k-h