From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
"Liu, Chuansheng" <chuansheng.liu@intel.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"pmladek@suse.com" <pmladek@suse.com>,
"sergey.senozhatsky@gmail.com" <sergey.senozhatsky@gmail.com>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"dvyukov@google.com" <dvyukov@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel/hung_task.c: force ignore_loglevel before panic
Date: Mon, 10 Dec 2018 19:30:29 +0900 [thread overview]
Message-ID: <20181210103029.GA29145@jagdpanzerIV> (raw)
In-Reply-To: <f6e39c8f-2ca2-4a01-cf42-9ed3bc2462a8@i-love.sakura.ne.jp>
On (12/10/18 18:58), Tetsuo Handa wrote:
> >>>> + */
> >>>> + if (sysctl_hung_task_panic && !ignore_loglevel)
> >>>> + ignore_loglevel = true;
> >>>
> >>> console_verbose()?
> >>
> >> Thanks Sergey, it is really my need. I will prepare for a new version of patch:)
> >
> > Let's wait for people to take a look at this patch first.
> Shouldn't console_verbose() be called like
>
> + if (sysctl_hung_task_panic)
> + console_verbose();
Sure, that was what I meant. IOW console_verbose() instead of
`ignore_loglevel = true' assignment.
-ss
next prev parent reply other threads:[~2018-12-10 10:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 5:40 [PATCH] kernel/hung_task.c: force ignore_loglevel before panic Liu, Chuansheng
2018-12-10 5:46 ` Sergey Senozhatsky
2018-12-10 5:58 ` Liu, Chuansheng
2018-12-10 6:11 ` Sergey Senozhatsky
2018-12-10 9:58 ` Tetsuo Handa
2018-12-10 10:30 ` Sergey Senozhatsky [this message]
2018-12-11 1:16 ` Liu, Chuansheng
2018-12-11 10:02 ` Tetsuo Handa
[not found] ` <27240C0AC20F114CBF8149A2696CBE4A6015B06E@SHSMSX101.ccr.corp.intel.com>
2018-12-12 10:17 ` Petr Mladek
2018-12-13 1:53 ` Liu, Chuansheng
2018-12-11 14:46 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210103029.GA29145@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=chuansheng.liu@intel.com \
--cc=dvyukov@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.