From: David Disseldorp <ddiss@suse.de>
To: target-devel@vger.kernel.org
Subject: Re: [RFC PATCH] target: sanitize ALUA and PR state file paths before use
Date: Mon, 10 Dec 2018 13:36:50 +0000 [thread overview]
Message-ID: <20181210143650.64c254df@suse.de> (raw)
In-Reply-To: <20181122133800.1251-1-ddiss@suse.de>
Ping - any feedback on this change?
On Thu, 22 Nov 2018 14:38:00 +0100, David Disseldorp wrote:
> Block ALUA and PR state storage if any of the dynamic subdirectory
> components include a path separator.
>
> Fixes: c66ac9db8d4a ("[SCSI] target: Add LIO target core v4.0.0-rc6")
> Signed-off-by: David Disseldorp <ddiss@suse.de>
> Signed-off-by: Lee Duncan <lduncan@suse.com>
> ---
> Note:
> Submitted as an RFC, as I've not properly tested the alua code path.
> I'm also not sure whether it's reasonable to break existing setups
> with a '/' in the configured unit_serial. Where "break" means fail
> APTPL PR requests; ALUA state-save failures are ignored internally.
I'd also be happy with any pointers on properly testing ALUA.
Cheers, David
next prev parent reply other threads:[~2018-12-10 13:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 13:38 [RFC PATCH] target: sanitize ALUA and PR state file paths before use David Disseldorp
2018-12-10 13:36 ` David Disseldorp [this message]
2018-12-10 19:19 ` Bart Van Assche
2018-12-10 19:35 ` David Disseldorp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210143650.64c254df@suse.de \
--to=ddiss@suse.de \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.