From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Habkost Subject: Re: kvm: RDTSCP on AMD Date: Mon, 10 Dec 2018 17:06:00 -0200 Message-ID: <20181210190600.GK4669@habkost.net> References: <20181210181328.GA762@zn.tnic> <20181210183730.GJ4669@habkost.net> <20181210184153.GB5482@zn.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Paolo Bonzini , =?iso-8859-1?Q?J=F6rg_R=F6del?= , Andre Przywara , kvm ML , lkml , Tom Lendacky To: Borislav Petkov Return-path: Content-Disposition: inline In-Reply-To: <20181210184153.GB5482@zn.tnic> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Mon, Dec 10, 2018 at 07:41:53PM +0100, Borislav Petkov wrote: > On Mon, Dec 10, 2018 at 04:37:30PM -0200, Eduardo Habkost wrote: > > It isn't as simply as reverting commit 33b5e8c03ae7, but we can > > surely re-add RDTSCP on pc-*-4.0 and newer. > > Sure. If you could only point me to an example how to add that to > pc-*-4.0 and newer, I'll gladly cook up a patch and test it. > > > I thought we added documentation mentioning the minimum kernel > > version required by QEMU, but I can't find it. In either case, > > it seems reasonable to require Linux 4.5 or newer on newer > > machine-types. > > When you say "require" does that mean, one puts it in a text file > somewhere in the qemu sources or do we enforce it somehow? I mean documenting it. We already have code that will print warnings if a feature isn't available. See my previous attempt to document the minimum kernel version at . -- Eduardo