All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] qt5base: do not change QMAKE_COMPILER in g++-base.conf
Date: Mon, 10 Dec 2018 20:50:49 +0100	[thread overview]
Message-ID: <20181210205049.2fc39576@windsurf> (raw)
In-Reply-To: <20181210194615.21904-1-ps.report@gmx.net>

Hello,

On Mon, 10 Dec 2018 20:46:15 +0100, Peter Seiderer wrote:
> The variable QMAKE_COMPILER determines the compiler flavour (e.g.
> gcc, clang, llvm, msvc etc.) and not a compiler path. Changing
> it confuses the platform test of the qt5webengine package
> (mkspecs/features/platform.prf):
> 
>   defineTest(isPlatformSupported) {
>     QT_FOR_CONFIG += gui-private
>     linux {
>       if(!gcc:!clang)|intel_icc {
>         skipBuild("Qt WebEngine on Linux requires clang or GCC.")
>         return(false)
>       }
>       gcc:!clang:!isGCCVersionSupported(): return(false)
>     }
>   }
> 
> Revert the variable change introduced by commit 'package/qt5/qt5base: use
> ccache for building host code' ([2]).
> 
> Fixes raspberrypi3_qt5we_defconfig/qt5webengine build ([1]):
> 
>   Qt WebEngine on Linux requires clang or GCC.
>   QtWebEngine will not be built.
> 
> [1] https://gitlab.com/buildroot.org/buildroot/-/jobs/131217091
> [2] https://git.buildroot.net/buildroot/commit/?id=c2ea056a1b34fd1354100d08e603b9374e225968
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
>  package/qt5/qt5base/qt5base.mk | 1 -
>  1 file changed, 1 deletion(-)

Applied to master, thanks. Thanks a lot for tracking this down and
fixing my mistake :-/

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2018-12-10 19:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-10 19:46 [Buildroot] [PATCH v1] qt5base: do not change QMAKE_COMPILER in g++-base.conf Peter Seiderer
2018-12-10 19:50 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181210205049.2fc39576@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.