From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/waf: purge trailig '/' from WAF_SITE
Date: Mon, 10 Dec 2018 22:02:04 +0100 [thread overview]
Message-ID: <20181210220204.32874db6@windsurf> (raw)
In-Reply-To: <8013501a-cffd-34e3-1fdd-1db64b51e4fe@mind.be>
Hello,
On Mon, 10 Dec 2018 21:59:37 +0100, Arnout Vandecappelle wrote:
> Because that check is within
>
> ifeq ($$($$($(2)_KCONFIG_VAR)),y)
> ...
> endif
>
> and these packages are host-only packages.
Aah, indeed.
> It has to be within that condition, since the _SITE may be set only or
> differently based on kconfig options which are only set when the package is
> selected. I tested and it fails for instance on arm-trusted-firmware if that
> package is not selected.
>
> We need Config.in.host :-)
Hehe, yes, we do :)
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-12-10 21:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 18:45 [Buildroot] [PATCH] package/waf: purge trailig '/' from WAF_SITE Carlos Santos
2018-12-10 19:45 ` Thomas Petazzoni
2018-12-10 20:59 ` Arnout Vandecappelle
2018-12-10 21:02 ` Thomas Petazzoni [this message]
2018-12-10 21:02 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210220204.32874db6@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.