From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
robh+dt@kernel.org, gregkh@linuxfoundation.org, arnd@arndb.de,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, bkumar@qti.qualcomm.com,
thierry.escande@linaro.org
Subject: Re: [PATCH v2 1/6] misc: dt-bindings: Add Qualcomm Fastrpc bindings
Date: Mon, 10 Dec 2018 16:10:50 -0800 [thread overview]
Message-ID: <20181211001050.GA1578@tuxbook-pro> (raw)
In-Reply-To: <afdeecc4-4ee9-e933-9917-9930ece85b00@linaro.org>
On Mon 10 Dec 03:17 PST 2018, Srinivas Kandagatla wrote:
> On 07/12/18 18:23, Mark Rutland wrote:
> > On Fri, Dec 07, 2018 at 04:35:08PM +0000, Srinivas Kandagatla wrote:
> > > diff --git a/Documentation/devicetree/bindings/misc/qcom,fastrpc.txt b/Documentation/devicetree/bindings/misc/qcom,fastrpc.txt
[..]
> > > +- reg
> > > + Usage: required
> > > + Value type: <u32>
> > > + Definition: DSP Processor ID.
> > > + Possible values are :
> > > + 0 - ADSP
> > > + 1 - MDSP
> > > + 2 - SDSP
> > > + 3 - CDSP
> >
> > Why is this in a reg?
>
> This is to identify which type of dsp(Audio/Modem/Sensor/Compute) it is,
> This information is used to create device nodes for user-space access.
>
But it does not represent FastRPC's address on the rpmsg bus. How about
replacing it with a "label" (or "qcom,domain" perhaps?) of type string?
Regards,
Bjorn
next prev parent reply other threads:[~2018-12-11 0:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 16:35 [PATCH v2 0/6] misc: Add support to Qualcomm FastRPC driver Srinivas Kandagatla
2018-12-07 16:35 ` [PATCH v2 1/6] misc: dt-bindings: Add Qualcomm Fastrpc bindings Srinivas Kandagatla
2018-12-07 18:23 ` Mark Rutland
2018-12-10 11:17 ` Srinivas Kandagatla
2018-12-11 0:10 ` Bjorn Andersson [this message]
2018-12-11 9:27 ` Srinivas Kandagatla
2018-12-11 10:50 ` Srinivas Kandagatla
2018-12-07 16:35 ` [PATCH v2 2/6] misc: fastrpc: Add Qualcomm fastrpc basic driver model Srinivas Kandagatla
2018-12-07 16:35 ` [PATCH v2 3/6] misc: fastrpc: Add support for context Invoke method Srinivas Kandagatla
2018-12-10 14:55 ` kbuild test robot
2018-12-10 14:55 ` kbuild test robot
2018-12-12 11:02 ` Greg KH
2018-12-12 11:14 ` Srinivas Kandagatla
2018-12-07 16:35 ` [PATCH v2 4/6] misc: fastrpc: Add support for create remote init process Srinivas Kandagatla
2018-12-07 16:35 ` [PATCH v2 5/6] misc: fastrpc: Add support for dmabuf exporter Srinivas Kandagatla
2018-12-07 16:35 ` [PATCH v2 6/6] misc: fastrpc: Add support for compat ioctls Srinivas Kandagatla
2018-12-12 10:59 ` Greg KH
2018-12-12 11:44 ` Srinivas Kandagatla
2018-12-12 11:50 ` Greg KH
2018-12-12 12:26 ` Srinivas Kandagatla
2018-12-12 13:41 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181211001050.GA1578@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=arnd@arndb.de \
--cc=bkumar@qti.qualcomm.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=thierry.escande@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.