From: Andrew Lunn <andrew@lunn.ch>
To: Tristram.Ha@microchip.com
Cc: netdev@vger.kernel.org, f.fainelli@gmail.com,
vivien.didelot@savoirfairelinux.com, Woojung.Huh@microchip.com,
UNGLinuxDriver@microchip.com, davem@davemloft.net, marex@denx.de
Subject: Re: [PATCH 3/5] net: dsa: ksz: Factor out common tag code
Date: Tue, 11 Dec 2018 08:40:00 +0100 [thread overview]
Message-ID: <20181211074000.GA31168@lunn.ch> (raw)
In-Reply-To: <SN1PR11MB0446A2B9B9A8782A8223680EECA50@SN1PR11MB0446.namprd11.prod.outlook.com>
> So this ksz_tag_ops is still not acceptable? As I understand the kernel is
> using this mechanism all over the places.
Hi Tristram
It is used all other the place, but generally, not in the hot path,
just the control plain.
> What is left is a direct copying of the transmit and receive functions for each
> new switch tail tag format.
As i said, one of these looks easy to achieve, the other i did not
look at too closely, but needs more work.
Andrew
next prev parent reply other threads:[~2018-12-11 7:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 18:18 [PATCH 1/5] net: dsa: ksz: Add MIB counter reading support Marek Vasut
2018-12-07 18:18 ` [PATCH 2/5] net: dsa: ksz: Rename NET_DSA_TAG_KSZ to _KSZ9477 Marek Vasut
2018-12-07 18:18 ` [PATCH 3/5] net: dsa: ksz: Factor out common tag code Marek Vasut
2018-12-08 11:34 ` Andrew Lunn
2018-12-10 20:32 ` Tristram.Ha
2018-12-10 21:58 ` Marek Vasut
2018-12-11 7:40 ` Andrew Lunn [this message]
2018-12-13 3:42 ` Marek Vasut
2018-12-07 18:18 ` [PATCH 4/5] net: dsa: ksz: Add KSZ8795 " Marek Vasut
2018-12-07 18:18 ` [PATCH 5/5] net: dsa: ksz: Add Microchip KSZ8795 DSA driver Marek Vasut
2018-12-08 11:52 ` Andrew Lunn
2018-12-07 20:56 ` [PATCH 1/5] net: dsa: ksz: Add MIB counter reading support David Miller
2018-12-08 11:16 ` Andrew Lunn
2018-12-10 13:27 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181211074000.GA31168@lunn.ch \
--to=andrew@lunn.ch \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.