From: Dan Carpenter <dan.carpenter@oracle.com>
To: Shreeya Patel <shreeya.patel23498@gmail.com>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
knaack.h@gmx.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] Staging: iio: adt7316: Move interrupt related code
Date: Tue, 11 Dec 2018 12:35:48 +0300 [thread overview]
Message-ID: <20181211093548.GA3116@kadam> (raw)
In-Reply-To: <20181208151638.8759-3-shreeya.patel23498@gmail.com>
On Sat, Dec 08, 2018 at 08:46:37PM +0530, Shreeya Patel wrote:
> - return irq_type;
> + ret = devm_request_threaded_irq(&indio_dev->dev, chip->bus.irq,
> + NULL, adt7316_event_handler,
> + irq_type | IRQF_ONESHOT,
> + indio_dev->name, indio_dev);
> + if (ret)
> + return ret;
> +
> + if (irq_type & IRQF_TRIGGER_HIGH)
> + chip->config1 |= ADT7316_INT_POLARITY;
> +
> + return ret;
return 0; here.
> }
>
> /*
regards,
dan carpenter
next prev parent reply other threads:[~2018-12-11 9:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-08 15:16 [PATCH v3 0/3] Remove platform data and introduce DT bindings Shreeya Patel
2018-12-08 15:16 ` [PATCH v3 1/3] Staging: iio: adt7316: Use device tree data to assign irq_type Shreeya Patel
2018-12-08 15:16 ` [PATCH v3 2/3] Staging: iio: adt7316: Move interrupt related code Shreeya Patel
2018-12-08 16:12 ` Jonathan Cameron
2018-12-08 16:44 ` Shreeya Patel
2018-12-11 9:35 ` Dan Carpenter [this message]
2018-12-08 15:16 ` [PATCH v3 3/3] Staging: iio: adt7316: Add a dev_err() message Shreeya Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181211093548.GA3116@kadam \
--to=dan.carpenter@oracle.com \
--cc=Michael.Hennerich@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=shreeya.patel23498@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.