From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Subject: Re: [Qemu-devel] [RFC 1/3] pvh: Add x86/HVM direct boot ABI header file Date: Tue, 11 Dec 2018 15:03:11 +0000 Message-ID: <20181211150311.GL921@redhat.com> References: <1544049446-6359-1-git-send-email-liam.merwick@oracle.com> <1544049446-6359-2-git-send-email-liam.merwick@oracle.com> <20181211140124.GA23460@stefanha-x1.localdomain> <83b577e6-691e-08b3-e9e4-90651e988ff2@oracle.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gWjZG-0007Tp-9X for xen-devel@lists.xenproject.org; Tue, 11 Dec 2018 15:03:26 +0000 Content-Disposition: inline In-Reply-To: <83b577e6-691e-08b3-e9e4-90651e988ff2@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Liam Merwick Cc: ehabkost@redhat.com, maran.wilson@oracle.com, mst@redhat.com, qemu-devel@nongnu.org, George Kennedy , Stefan Hajnoczi , pbonzini@redhat.com, xen-devel@lists.xenproject.org, Boris Ostrovsky , sgarzare@redhat.com, rth@twiddle.net List-Id: xen-devel@lists.xenproject.org T24gVHVlLCBEZWMgMTEsIDIwMTggYXQgMDI6NTc6MjlQTSArMDAwMCwgTGlhbSBNZXJ3aWNrIHdy b3RlOgo+IAo+IAo+IE9uIDExLzEyLzIwMTggMTQ6MDEsIFN0ZWZhbiBIYWpub2N6aSB3cm90ZToK PiA+IE9uIFdlZCwgRGVjIDA1LCAyMDE4IGF0IDEwOjM3OjI0UE0gKzAwMDAsIExpYW0gTWVyd2lj ayB3cm90ZToKPiA+ID4gRnJvbTogTGlhbSBNZXJ3aWNrIDxMaWFtLk1lcndpY2tAb3JhY2xlLmNv bT4KPiA+ID4gCj4gPiA+IFRoZSB4ODYvSFZNIGRpcmVjdCBib290IEFCSSBwZXJtaXRzIFFlbXUg dG8gYmUgYWJsZSB0byBib290IGRpcmVjdGx5Cj4gPiA+IGludG8gdGhlIHVuY29tcHJlc3NlZCBM aW51eCBrZXJuZWwgYmluYXJ5IHdpdGhvdXQgdGhlIG5lZWQgdG8gcnVuIGZpcm13YXJlLgo+ID4g PiAKPiA+ID4gCWh0dHBzOi8veGVuYml0cy54ZW4ub3JnL2RvY3MvdW5zdGFibGUvbWlzYy9wdmgu aHRtbAo+ID4gPiAKPiA+ID4gVGhpcyBjb21taXQgYWRkcyB0aGUgaGVhZGVyIGZpbGUgdGhhdCBk ZWZpbmVzIHRoZSBzdGFydF9pbmZvIHN0cnVjdAo+ID4gPiB0aGF0IG5lZWRzIHRvIGJlIHBvcHVs YXRlZCBpbiBvcmRlciB0byB1c2UgdGhpcyBBQkkuCj4gPiA+IAo+ID4gPiBTaWduZWQtb2ZmLWJ5 OiBNYXJhbiBXaWxzb24gPE1hcmFuLldpbHNvbkBvcmFjbGUuY29tPgo+ID4gPiBTaWduZWQtb2Zm LWJ5OiBMaWFtIE1lcndpY2sgPExpYW0uTWVyd2lja0BvcmFjbGUuY29tPgo+ID4gPiBSZXZpZXdl ZC1ieTogS29ucmFkIFJ6ZXN6dXRlayBXaWxrIDxLb25yYWQuV2lsa0BvcmFjbGUuY29tPgo+ID4g PiAtLS0KPiA+ID4gICBpbmNsdWRlL2h3L3hlbi9zdGFydF9pbmZvLmggfCAxNDYgKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiA+ID4gICAxIGZpbGUgY2hhbmdl ZCwgMTQ2IGluc2VydGlvbnMoKykKPiA+ID4gICBjcmVhdGUgbW9kZSAxMDA2NDQgaW5jbHVkZS9o dy94ZW4vc3RhcnRfaW5mby5oCj4gPiAKPiA+IERvZXMgaXQgbWFrZSBzZW5zZSB0byBicmluZyBp biBMaW51eAo+ID4gaW5jbHVkZS94ZW4vaW50ZXJmYWNlL2h2bS9zdGFydF9pbmZvLmggdmlhIFFF TVUncwo+ID4gaW5jbHVkZS9zdGFuZGFyZC1oZWFkZXJzLz8KPiA+IAo+ID4gUUVNVSBoYXMgYSBz Y3JpcHQgaW4gc2NyaXB0cy91cGRhdGUtbGludXgtaGVhZGVyLnNoIGZvciBzeW5jaW5nIExpbnV4 Cj4gPiBoZWFkZXJzIGludG8gaW5jbHVkZS9zdGFuZGFyZC1oZWFkZXJzLy4gIFRoaXMgbWFrZXMg aXQgZWFzeSB0byBrZWVwCj4gPiBMaW51eCBoZWFkZXIgZmlsZXMgdXAtdG8tZGF0ZS4gIFdlIGJh c2ljYWxseSB0cmVhdCBmaWxlcyBpbgo+ID4gaW5jbHVkZS9zdGFuZGFyZC1oZWFkZXJzLyBhcyBh dXRvLWdlbmVyYXRlZC4KPiA+IAo+ID4gSWYgeW91IGRlZmluZSBzdGFydF9pbmZvLmggeW91cnNl bGYgd2l0aG91dCB1c2luZwo+ID4gaW5jbHVkZS9zdGFuZGFyZC1oZWFkZXJzLywgdGhlbiBpdCB3 b24ndCBiZSBzeW5jZWQgd2l0aCBMaW51eC4KPiA+IAo+IAo+IFRoYXQgZG9lcyBzZWVtIGJldHRl ci4gIEkgd2lsbCBtYWtlIHRoYXQgY2hhbmdlLgo+IAo+IE9uZSBhIHJlbGF0ZWQgbm90ZSwgSSdt IHRyeWluZyB0byBmaXggdGhlIG1pbmd3IGNvbXBpbGF0aW9uIGVycm9ycyBbMV0gaW4KPiB0aGlz IHNlcmllcyBhbHNvLiAgSSBjYW4gZml4IHRoZSBmb3JtYXQgaXNzdWVzIHdpdGggUFJJeDY0LCBl dGMgYnV0IEkgY2FuJ3QKPiBzZWVtIHRvIGZpbmQgYW4gaW5jbHVkZSBmaWxlIHRvIHByb3ZpZGUg YSBkZWNsYXJhdGlvbiBvZiBtbWFwKCkgZXQuIGFsLiAtCj4gaGFzIHRoaXMgYmVlbiByZXNvbHZl ZCBiZWZvcmU/IEEgcG9pbnRlciB0byBzb21ldGhpbmcgc2ltaWxhciB0byBpbnZlc3RpZ2F0ZQo+ IHdvdWxkIGJlIHZlcnkgd2VsY29tZS4KClRoZXJlIGlzIG5vIG1tYXAoKSBvbiBtaW5ndywgc28g eW91J2xsIGhhdmUgdG8gbWFrZSBzdXJlIHRoYXQgY29kZSBpcwpjb25kaXRpb25hbGx5IGNvbXBp bGVkIHdpdGggICNpZm5kZWYgV0lOMzIgd2hlcmUgYXBwcm9wcmlhdGUuCgo+IFsxXSBodHRwOi8v cGF0Y2hldy5vcmcvbG9ncy8xNTQ0MDQ5NDQ2LTYzNTktMS1naXQtc2VuZC1lbWFpbC1saWFtLm1l cndpY2tAb3JhY2xlLmNvbS90ZXN0aW5nLmRvY2tlci1taW5nd0BmZWRvcmEvP3R5cGU9bWVzc2Fn ZQo+IAoKUmVnYXJkcywKRGFuaWVsCi0tIAp8OiBodHRwczovL2JlcnJhbmdlLmNvbSAgICAgIC1v LSAgICBodHRwczovL3d3dy5mbGlja3IuY29tL3Bob3Rvcy9kYmVycmFuZ2UgOnwKfDogaHR0cHM6 Ly9saWJ2aXJ0Lm9yZyAgICAgICAgIC1vLSAgICAgICAgICAgIGh0dHBzOi8vZnN0b3AxMzguYmVy cmFuZ2UuY29tIDp8Cnw6IGh0dHBzOi8vZW50YW5nbGUtcGhvdG8ub3JnICAgIC1vLSAgICBodHRw czovL3d3dy5pbnN0YWdyYW0uY29tL2RiZXJyYW5nZSA6fAoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2 ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWls bWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51525) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gWjZI-00071E-VA for qemu-devel@nongnu.org; Tue, 11 Dec 2018 10:03:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gWjZF-0006YY-6y for qemu-devel@nongnu.org; Tue, 11 Dec 2018 10:03:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39960) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gWjZE-0006Xv-VM for qemu-devel@nongnu.org; Tue, 11 Dec 2018 10:03:25 -0500 Date: Tue, 11 Dec 2018 15:03:11 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20181211150311.GL921@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <1544049446-6359-1-git-send-email-liam.merwick@oracle.com> <1544049446-6359-2-git-send-email-liam.merwick@oracle.com> <20181211140124.GA23460@stefanha-x1.localdomain> <83b577e6-691e-08b3-e9e4-90651e988ff2@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <83b577e6-691e-08b3-e9e4-90651e988ff2@oracle.com> Subject: Re: [Qemu-devel] [RFC 1/3] pvh: Add x86/HVM direct boot ABI header file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liam Merwick Cc: Stefan Hajnoczi , ehabkost@redhat.com, mst@redhat.com, maran.wilson@oracle.com, qemu-devel@nongnu.org, George Kennedy , xen-devel@lists.xenproject.org, pbonzini@redhat.com, Boris Ostrovsky , rth@twiddle.net, sgarzare@redhat.com On Tue, Dec 11, 2018 at 02:57:29PM +0000, Liam Merwick wrote: > > > On 11/12/2018 14:01, Stefan Hajnoczi wrote: > > On Wed, Dec 05, 2018 at 10:37:24PM +0000, Liam Merwick wrote: > > > From: Liam Merwick > > > > > > The x86/HVM direct boot ABI permits Qemu to be able to boot directly > > > into the uncompressed Linux kernel binary without the need to run firmware. > > > > > > https://xenbits.xen.org/docs/unstable/misc/pvh.html > > > > > > This commit adds the header file that defines the start_info struct > > > that needs to be populated in order to use this ABI. > > > > > > Signed-off-by: Maran Wilson > > > Signed-off-by: Liam Merwick > > > Reviewed-by: Konrad Rzeszutek Wilk > > > --- > > > include/hw/xen/start_info.h | 146 ++++++++++++++++++++++++++++++++++++++++++++ > > > 1 file changed, 146 insertions(+) > > > create mode 100644 include/hw/xen/start_info.h > > > > Does it make sense to bring in Linux > > include/xen/interface/hvm/start_info.h via QEMU's > > include/standard-headers/? > > > > QEMU has a script in scripts/update-linux-header.sh for syncing Linux > > headers into include/standard-headers/. This makes it easy to keep > > Linux header files up-to-date. We basically treat files in > > include/standard-headers/ as auto-generated. > > > > If you define start_info.h yourself without using > > include/standard-headers/, then it won't be synced with Linux. > > > > That does seem better. I will make that change. > > One a related note, I'm trying to fix the mingw compilation errors [1] in > this series also. I can fix the format issues with PRIx64, etc but I can't > seem to find an include file to provide a declaration of mmap() et. al. - > has this been resolved before? A pointer to something similar to investigate > would be very welcome. There is no mmap() on mingw, so you'll have to make sure that code is conditionally compiled with #ifndef WIN32 where appropriate. > [1] http://patchew.org/logs/1544049446-6359-1-git-send-email-liam.merwick@oracle.com/testing.docker-mingw@fedora/?type=message > Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|