From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony PERARD Subject: Re: [PATCH v3 04/18] xen: create xenstore areas for XenDevice-s Date: Tue, 11 Dec 2018 15:19:47 +0000 Message-ID: <20181211151947.GR18875@perard.uk.xensource.com> References: <1544525238-3527-1-git-send-email-paul.durrant@citrix.com> <1544525238-3527-5-git-send-email-paul.durrant@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gWjpA-0000X7-EB for xen-devel@lists.xenproject.org; Tue, 11 Dec 2018 15:19:52 +0000 Content-Disposition: inline In-Reply-To: <1544525238-3527-5-git-send-email-paul.durrant@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Paul Durrant Cc: Kevin Wolf , Stefano Stabellini , qemu-block@nongnu.org, qemu-devel@nongnu.org, Max Reitz , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org T24gVHVlLCBEZWMgMTEsIDIwMTggYXQgMTA6NDc6MDRBTSArMDAwMCwgUGF1bCBEdXJyYW50IHdy b3RlOgo+IFRoaXMgcGF0Y2ggYWRkcyBhIG5ldyBzb3VyY2UgbW9kdWxlLCB4ZW4tYnVzLWhlbHBl ci5jLCB3aGljaCBidWlsZHMgb24KPiBiYXNpYyBsaWJ4ZW5zdG9yZSBwcmltaXRpdmVzIHRvIHBy b3ZpZGUgZnVuY3Rpb25zIHRvIGNyZWF0ZSAoc2V0dGluZwo+IHBlcm1pc3Npb25zIGFwcHJvcHJp YXRlbHkpIGFuZCBkZXN0cm95IHhlbnN0b3JlIGFyZWFzLCBhbmQgZnVuY3Rpb25zIHRvCj4gJ3By aW50ZicgYW5kICdzY2FuZicgbm9kZXMgdGhlcmVpbi4gVGhlIG1haW4geGVuLWJ1cyBjb2RlIHRo ZW4gdXNlcwo+IHRoZXNlIHByaW1pdGl2ZXMgWzFdIHRvIGluaXRpYWxpemUgYW5kIGRlc3Ryb3kg dGhlIGZyb250ZW5kIGFuZCBiYWNrZW5kCj4gYXJlYXMgZm9yIGEgWGVuRGV2aWNlIGR1cmluZyBy ZWFsaXplIGFuZCB1bnJlYWxpemUgcmVzcGVjdGl2ZWx5Lgo+IAo+IFRoZSAneGVuLWJsb2NrJyBp bXBsZW1lbnRhdGlvbiBpcyBleHRlbmRlZCB3aXRoIGEgJ2dldF9uYW1lJyBtZXRob2QgdGhhdAo+ IHJldHVybnMgdGhlIFZCRCBudW1iZXIuIFRoaXMgbnVtYmVyIGlzIHJlcXVpcmVkIHRvICduYW1l JyB0aGUgeGVuc3RvcmUKPiBhcmVhcy4KPiAKPiBOT1RFOiBBbiBleGl0IGhhbmRsZXIgaXMgYWxz byBhZGRlZCB0byBtYWtlIHN1cmUgdGhlIHhlbnN0b3JlIGFyZWFzIGFyZQo+ICAgICAgIGNsZWFu ZWQgdXAgaWYgUUVNVSB0ZXJtaW5hdGVzIHdpdGhvdXQgZGV2aWNlcyBiZWluZyB1bnJlYWxpemVk Lgo+IAo+IFsxXSBUaGUgJ3NjYW5mJyBmdW5jdGlvbnMgYXJlIGFjdHVhbGx5IG5vdCB5ZXQgbmVl ZGVkLCBidXQgdGhleSB3aWxsIGJlCj4gICAgIG5lZWRlZCBieSBjb2RlIGRlbGl2ZXJlZCBpbiBz dWJzZXF1ZW50IHBhdGNoZXMuCj4gCj4gU2lnbmVkLW9mZi1ieTogUGF1bCBEdXJyYW50IDxwYXVs LmR1cnJhbnRAY2l0cml4LmNvbT4KPiAtLS0KPiAKPiB2MzoKPiAgLSBBZGQgdHJhbnNhY3Rpb24g aWQgcGFyYW1ldGVycyB0byB4ZW4tYnVzLWhlbHBlciBmdW5jdGlvbnMKPiAgLSBOb3QgYWRkZWQg QW50aG9ueSdzIFItYiBiZWNhdXNlIG9mIGNoYW5nZQo+IAoKUmV2aWV3ZWQtYnk6IEFudGhvbnkg UEVSQVJEIDxhbnRob255LnBlcmFyZEBjaXRyaXguY29tPgoKLS0gCkFudGhvbnkgUEVSQVJECgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwg bWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3Rz LnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56994) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gWjpF-0003Ne-Qq for qemu-devel@nongnu.org; Tue, 11 Dec 2018 10:19:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gWjpA-00011V-Vu for qemu-devel@nongnu.org; Tue, 11 Dec 2018 10:19:57 -0500 Date: Tue, 11 Dec 2018 15:19:47 +0000 From: Anthony PERARD Message-ID: <20181211151947.GR18875@perard.uk.xensource.com> References: <1544525238-3527-1-git-send-email-paul.durrant@citrix.com> <1544525238-3527-5-git-send-email-paul.durrant@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1544525238-3527-5-git-send-email-paul.durrant@citrix.com> Subject: Re: [Qemu-devel] [PATCH v3 04/18] xen: create xenstore areas for XenDevice-s List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Durrant Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, xen-devel@lists.xenproject.org, Stefano Stabellini , Kevin Wolf , Max Reitz On Tue, Dec 11, 2018 at 10:47:04AM +0000, Paul Durrant wrote: > This patch adds a new source module, xen-bus-helper.c, which builds on > basic libxenstore primitives to provide functions to create (setting > permissions appropriately) and destroy xenstore areas, and functions to > 'printf' and 'scanf' nodes therein. The main xen-bus code then uses > these primitives [1] to initialize and destroy the frontend and backend > areas for a XenDevice during realize and unrealize respectively. > > The 'xen-block' implementation is extended with a 'get_name' method that > returns the VBD number. This number is required to 'name' the xenstore > areas. > > NOTE: An exit handler is also added to make sure the xenstore areas are > cleaned up if QEMU terminates without devices being unrealized. > > [1] The 'scanf' functions are actually not yet needed, but they will be > needed by code delivered in subsequent patches. > > Signed-off-by: Paul Durrant > --- > > v3: > - Add transaction id parameters to xen-bus-helper functions > - Not added Anthony's R-b because of change > Reviewed-by: Anthony PERARD -- Anthony PERARD