From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony PERARD Subject: Re: [PATCH v3 09/18] xen: remove unnecessary code from dataplane/xen-block.c Date: Tue, 11 Dec 2018 15:30:21 +0000 Message-ID: <20181211153021.GA16149@perard.uk.xensource.com> References: <1544525238-3527-1-git-send-email-paul.durrant@citrix.com> <1544525238-3527-10-git-send-email-paul.durrant@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gWjzU-0002TF-1e for xen-devel@lists.xenproject.org; Tue, 11 Dec 2018 15:30:32 +0000 Content-Disposition: inline In-Reply-To: <1544525238-3527-10-git-send-email-paul.durrant@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Paul Durrant Cc: Kevin Wolf , Stefano Stabellini , qemu-block@nongnu.org, qemu-devel@nongnu.org, Max Reitz , Stefan Hajnoczi , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org T24gVHVlLCBEZWMgMTEsIDIwMTggYXQgMTA6NDc6MDlBTSArMDAwMCwgUGF1bCBEdXJyYW50IHdy b3RlOgo+IHYyOgo+ICAtIExlYXZlIGV4aXN0aW5nIGJvaWxlcnBsYXRlIGFsb25lLCBvdGhlciB0 aGFuIHJlbW92aW5nIHRoZSBub3ctaW5jb3JyZWN0Cj4gICAgZGVzY3JpcHRpb24KPiAtLS0KPiAg aHcvYmxvY2svZGF0YXBsYW5lL3hlbi1ibG9jay5jIHwgNDA5ICsrLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCsp LCAzOTMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2h3L2Jsb2NrL2RhdGFwbGFuZS94 ZW4tYmxvY2suYyBiL2h3L2Jsb2NrL2RhdGFwbGFuZS94ZW4tYmxvY2suYwo+IGluZGV4IDlmYWU1 MDUuLjk4Zjk4N2QgMTAwNjQ0Cj4gLS0tIGEvaHcvYmxvY2svZGF0YXBsYW5lL3hlbi1ibG9jay5j Cj4gKysrIGIvaHcvYmxvY2svZGF0YXBsYW5lL3hlbi1ibG9jay5jCj4gQEAgLTEsNiArMSw0IEBA Cj4gIC8qCj4gLSAqICB4ZW4gcGFyYXZpcnQgYmxvY2sgZGV2aWNlIGJhY2tlbmQKPiAtICoKPiAg ICogIChjKSBHZXJkIEhvZmZtYW5uIDxrcmF4ZWxAcmVkaGF0LmNvbT4KPiAgICoKPiAgICogIFRo aXMgcHJvZ3JhbSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQv b3IgbW9kaWZ5Cj4gQEAgLTE5LDI2ICsxNywxMiBAQAo+ICAgKiAgR05VIEdQTCwgdmVyc2lvbiAy IG9yIChhdCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24uCj4gICAqLwo+ICAKPiArLyoK PiArICogQ29weXJpZ2h0IChjKSAyMDE4ICBDaXRyaXggU3lzdGVtcyBJbmMuCgpDYW4geW91IG1v dmUgdGhpcyBjb3B5cmlnaHQgbGluZSB0byB0aGUgZXhpc3RpbmcgbGljZW5zZSBib2lsZXJwbGF0 ZSBhcwpJJ3ZlIGFza2VkIG9uIHYyPwoKPiArICoKPiArICogVGhpcyB3b3JrIGlzIGxpY2Vuc2Vk IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdQTCwgdmVyc2lvbiAyIG9yIGxhdGVyLgo+ICsg KiBTZWUgdGhlIENPUFlJTkcgZmlsZSBpbiB0aGUgdG9wLWxldmVsIGRpcmVjdG9yeS4KCkFuZCB0 aGlzIGlzbid0IG5lZWRlZCBhcyBpdCBqdXN0IGR1cGxpY2F0ZSB0aGUgYWxyZWFkeSBleGlzdGlu ZyBvbmUuCgo+ICsgKi8KPiAgCgpUaGFua3MsCgotLSAKQW50aG9ueSBQRVJBUkQKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5n IGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJv amVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60883) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gWjzZ-0004Z9-3t for qemu-devel@nongnu.org; Tue, 11 Dec 2018 10:30:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gWjzT-00038O-Ix for qemu-devel@nongnu.org; Tue, 11 Dec 2018 10:30:37 -0500 Date: Tue, 11 Dec 2018 15:30:21 +0000 From: Anthony PERARD Message-ID: <20181211153021.GA16149@perard.uk.xensource.com> References: <1544525238-3527-1-git-send-email-paul.durrant@citrix.com> <1544525238-3527-10-git-send-email-paul.durrant@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1544525238-3527-10-git-send-email-paul.durrant@citrix.com> Subject: Re: [Qemu-devel] [Xen-devel] [PATCH v3 09/18] xen: remove unnecessary code from dataplane/xen-block.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Durrant Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, xen-devel@lists.xenproject.org, Kevin Wolf , Stefano Stabellini , Stefan Hajnoczi , Max Reitz On Tue, Dec 11, 2018 at 10:47:09AM +0000, Paul Durrant wrote: > v2: > - Leave existing boilerplate alone, other than removing the now-incorrect > description > --- > hw/block/dataplane/xen-block.c | 409 ++--------------------------------------- > 1 file changed, 16 insertions(+), 393 deletions(-) > > diff --git a/hw/block/dataplane/xen-block.c b/hw/block/dataplane/xen-block.c > index 9fae505..98f987d 100644 > --- a/hw/block/dataplane/xen-block.c > +++ b/hw/block/dataplane/xen-block.c > @@ -1,6 +1,4 @@ > /* > - * xen paravirt block device backend > - * > * (c) Gerd Hoffmann > * > * This program is free software; you can redistribute it and/or modify > @@ -19,26 +17,12 @@ > * GNU GPL, version 2 or (at your option) any later version. > */ > > +/* > + * Copyright (c) 2018 Citrix Systems Inc. Can you move this copyright line to the existing license boilerplate as I've asked on v2? > + * > + * This work is licensed under the terms of the GNU GPL, version 2 or later. > + * See the COPYING file in the top-level directory. And this isn't needed as it just duplicate the already existing one. > + */ > Thanks, -- Anthony PERARD