From: Bart Van Assche <bvanassche@acm.org>
To: peterz@infradead.org
Cc: mingo@redhat.com, tj@kernel.org, longman@redhat.com,
johannes.berg@intel.com, linux-kernel@vger.kernel.org,
Bart Van Assche <bvanassche@acm.org>,
Johannes Berg <johannes@sipsolutions.net>
Subject: [PATCH v4 06/15] locking/lockdep: Make it easy to detect whether or not inside a selftest
Date: Tue, 11 Dec 2018 14:13:12 -0800 [thread overview]
Message-ID: <20181211221321.196536-7-bvanassche@acm.org> (raw)
In-Reply-To: <20181211221321.196536-1-bvanassche@acm.org>
The patch that frees unused lock classes will modify the behavior of
lockdep_free_key_range() and lockdep_reset_lock() depending on whether
or not these functions are called from the context of the lockdep
selftests. Hence make it easy to detect whether or not lockdep code
is called from the context of a lockdep selftest.
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Waiman Long <longman@redhat.com>
Cc: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
include/linux/lockdep.h | 2 ++
kernel/locking/lockdep.c | 1 +
lib/locking-selftest.c | 2 ++
3 files changed, 5 insertions(+)
diff --git a/include/linux/lockdep.h b/include/linux/lockdep.h
index b5e6bfe0ae4a..16ac9fe56783 100644
--- a/include/linux/lockdep.h
+++ b/include/linux/lockdep.h
@@ -466,6 +466,8 @@ enum xhlock_context_t {
#define STATIC_LOCKDEP_MAP_INIT(_name, _key) \
{ .name = (_name), .key = (void *)(_key), }
+extern struct task_struct *lockdep_selftest_task_struct;
+
static inline void lockdep_invariant_state(bool force) {}
static inline void lockdep_init_task(struct task_struct *task) {}
static inline void lockdep_free_task(struct task_struct *task) {}
diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
index 4fcc2a07bfb4..aeb775a4bed3 100644
--- a/kernel/locking/lockdep.c
+++ b/kernel/locking/lockdep.c
@@ -81,6 +81,7 @@ module_param(lock_stat, int, 0644);
* code to recurse back into the lockdep code...
*/
static arch_spinlock_t lockdep_lock = (arch_spinlock_t)__ARCH_SPIN_LOCK_UNLOCKED;
+struct task_struct *lockdep_selftest_task_struct;
static int graph_lock(void)
{
diff --git a/lib/locking-selftest.c b/lib/locking-selftest.c
index 1e1bbf171eca..b37fd3fe7fd6 100644
--- a/lib/locking-selftest.c
+++ b/lib/locking-selftest.c
@@ -1989,6 +1989,7 @@ void locking_selftest(void)
init_shared_classes();
debug_locks_silent = !debug_locks_verbose;
+ lockdep_selftest_task_struct = current;
DO_TESTCASE_6R("A-A deadlock", AA);
DO_TESTCASE_6R("A-B-B-A deadlock", ABBA);
@@ -2097,5 +2098,6 @@ void locking_selftest(void)
printk("---------------------------------\n");
debug_locks = 1;
}
+ lockdep_selftest_task_struct = NULL;
debug_locks_silent = 0;
}
--
2.20.0.rc2.403.gdbc3b29805-goog
next prev parent reply other threads:[~2018-12-11 22:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 22:13 [PATCH v4 00/15] locking/lockdep: Add support for dynamic keys Bart Van Assche
2018-12-11 22:13 ` [PATCH v4 01/15] locking/lockdep: Fix required memory size reported if CONFIG_PROVE_LOCKING=n Bart Van Assche
2018-12-11 22:13 ` [PATCH v4 02/15] locking/lockdep: Make zap_class() remove all matching lock order entries Bart Van Assche
2018-12-11 22:13 ` [PATCH v4 03/15] locking/lockdep: Reorder struct lock_class members Bart Van Assche
2018-12-11 22:13 ` [PATCH v4 04/15] locking/lockdep: Initialize the locks_before and locks_after lists earlier Bart Van Assche
2018-12-11 22:13 ` [PATCH v4 05/15] locking/lockdep: Split lockdep_free_key_range() and lockdep_reset_lock() Bart Van Assche
2018-12-11 22:13 ` Bart Van Assche [this message]
2018-12-11 22:13 ` [PATCH v4 07/15] locking/lockdep: Free lock classes that are no longer in use Bart Van Assche
2018-12-11 22:13 ` [PATCH v4 08/15] locking/lockdep: Reuse list entries " Bart Van Assche
2018-12-11 22:13 ` [PATCH v4 09/15] locking/lockdep: Introduce lockdep_next_lockchain() and lock_chain_count() Bart Van Assche
2018-12-11 22:13 ` [PATCH v4 10/15] locking/lockdep: Reuse lock chains that have been freed Bart Van Assche
2018-12-11 22:13 ` [PATCH v4 11/15] locking/lockdep: Check data structure consistency Bart Van Assche
2018-12-11 22:13 ` [PATCH v4 12/15] locking/lockdep: Verify whether lock objects are small enough to be used as class keys Bart Van Assche
2018-12-11 22:13 ` [PATCH v4 13/15] locking/lockdep: Add support for dynamic keys Bart Van Assche
2018-12-14 17:20 ` Bart Van Assche
2018-12-11 22:13 ` [PATCH v4 14/15] kernel/workqueue: Use dynamic lockdep keys for workqueues Bart Van Assche
2018-12-11 22:13 ` [PATCH v4 15/15] lockdep tests: Test dynamic key registration Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181211221321.196536-7-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.