All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerome Glisse <jglisse@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: David Rientjes <rientjes@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Michal Hocko <mhocko@suse.com>,
	Mike Rapoport <rppt@linux.vnet.ibm.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/mmu_notifier: fix mmu_notifier_range_init warning
Date: Tue, 11 Dec 2018 17:19:35 -0500	[thread overview]
Message-ID: <20181211221935.GC6478@redhat.com> (raw)
In-Reply-To: <CAK8P3a1yn7RAp7Q29dx5Rcb0mCoDpcHPzxSGqKHdgfJd+=iiNw@mail.gmail.com>

On Tue, Dec 11, 2018 at 10:53:03PM +0100, Arnd Bergmann wrote:
> On Tue, Dec 11, 2018 at 10:43 PM David Rientjes <rientjes@google.com> wrote:
> >
> > On Tue, 11 Dec 2018, Jerome Glisse wrote:
> 
> >
> > Hmm, strange that Arnd's build failure is only reporting about an unused
> > variable instead of MMU_NOTIFY_CLEAR being undefined :/
> >
> > I think this should be done so that anybody using
> > mmu_notifier_range_init() doesn't need to worry about the implications of
> > *any* unused formal parameter as a result of how the #define is formed:
> 
> Your patch below is more or less what I tried at first, and that resulted
> in another build failure for
> 
> mm/hugetlb.c:   mmu_notifier_range_init(&range, mm, start, end,
> MMU_NOTIFY_CLEAR);
> mm/hugetlb.c-   adjust_range_if_pmd_sharing_possible(vma,
> &range.start, &range.end);
> 
> where range.end refers to a nonexisting member of range.
> 
>           Arnd

I will post a v3 with htmldoc fix and build warning fix incorporated.

Cheers,
Jérôme

  reply	other threads:[~2018-12-11 22:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-11 20:04 [PATCH] mm/mmu_notifier: fix mmu_notifier_range_init warning Arnd Bergmann
2018-12-11 20:19 ` Jerome Glisse
2018-12-11 21:12   ` David Rientjes
2018-12-11 21:36     ` Jerome Glisse
2018-12-11 21:43       ` David Rientjes
2018-12-11 21:53         ` Arnd Bergmann
2018-12-11 22:19           ` Jerome Glisse [this message]
2018-12-11 22:25           ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181211221935.GC6478@redhat.com \
    --to=jglisse@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhocko@suse.com \
    --cc=rientjes@google.com \
    --cc=rppt@linux.vnet.ibm.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.