From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH net 2/4] vhost_net: rework on the lock ordering for busy polling Date: Tue, 11 Dec 2018 22:40:45 -0500 Message-ID: <20181211224024-mutt-send-email-mst@kernel.org> References: <20181210094454.21144-1-jasowang@redhat.com> <20181210094454.21144-3-jasowang@redhat.com> <20181210203119-mutt-send-email-mst@kernel.org> <20181210230106-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Jason Wang Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org T24gV2VkLCBEZWMgMTIsIDIwMTggYXQgMTE6MDM6NTdBTSArMDgwMCwgSmFzb24gV2FuZyB3cm90 ZToKPiAKPiBPbiAyMDE4LzEyLzExIOS4i+WNiDEyOjA0LCBNaWNoYWVsIFMuIFRzaXJraW4gd3Jv dGU6Cj4gPiBPbiBUdWUsIERlYyAxMSwgMjAxOCBhdCAxMTowNjo0M0FNICswODAwLCBKYXNvbiBX YW5nIHdyb3RlOgo+ID4gPiBPbiAyMDE4LzEyLzExIOS4iuWNiDk6MzQsIE1pY2hhZWwgUy4gVHNp cmtpbiB3cm90ZToKPiA+ID4gPiBPbiBNb24sIERlYyAxMCwgMjAxOCBhdCAwNTo0NDo1MlBNICsw ODAwLCBKYXNvbiBXYW5nIHdyb3RlOgo+ID4gPiA+ID4gV2hlbiB3ZSB0cnkgdG8gZG8gcnggYnVz eSBwb2xsaW5nIGluIHR4IHBhdGggaW4gY29tbWl0IDQ0MWFiZGU0Y2Q4NAo+ID4gPiA+ID4gKCJu ZXQ6IHZob3N0OiBhZGQgcnggYnVzeSBwb2xsaW5nIGluIHR4IHBhdGgiKSwgd2UgbG9jayByeCB2 cSBtdXRleAo+ID4gPiA+ID4gYWZ0ZXIgdHggdnEgbXV0ZXggaXMgaGVsZC4gVGhpcyBtYXkgbGVh ZCBkZWFkbG9jayBzbyB3ZSB0cnkgdG8gbG9jayB2cQo+ID4gPiA+ID4gb25lIGJ5IG9uZSBpbiBj b21taXQgNzgxMzljOTRkYzhjICgibmV0OiB2aG9zdDogbG9jayB0aGUgdnFzIG9uZSBieQo+ID4g PiA+ID4gb25lIikuIFdpdGggdGhpcyBjb21taXQsIHdlIGF2b2lkIHRoZSBkZWFkbG9jayB3aXRo IHRoZSBhc3N1bXB0aW9uCj4gPiA+ID4gPiB0aGF0IGhhbmRsZV9yeCgpIGFuZCBoYW5kbGVfdHgo KSBydW4gaW4gYSBzYW1lIHByb2Nlc3MuIEJ1dCB0aGlzCj4gPiA+ID4gPiBjb21taXQgcmVtb3Zl IHRoZSBwcm90ZWN0aW9uIGZvciBJT1RMQiB1cGRhdGluZyB3aGljaCByZXF1aXJlcyB0aGUKPiA+ ID4gPiA+IG11dGV4IG9mIGVhY2ggdnEgdG8gYmUgaGVsZC4KPiA+ID4gPiA+IAo+ID4gPiA+ID4g VG8gc29sdmUgdGhpcyBpc3N1ZSwgdGhlIGZpcnN0IHN0ZXAgaXMgdG8gaGF2ZSBhIGV4YWN0IHNh bWUgbG9jawo+ID4gPiA+ID4gb3JkZXJpbmcgZm9yIHZob3N0X25ldC4gVGhpcyBpcyBkb25lIHRo cm91Z2g6Cj4gPiA+ID4gPiAKPiA+ID4gPiA+IC0gRm9yIGhhbmRsZV9yeCgpLCBpZiBidXN5IHBv bGxpbmcgaXMgZW5hYmxlZCwgbG9jayB0eCB2cSBpbW1lZGlhdGVseS4KPiA+ID4gPiA+IC0gRm9y IGhhbmRsZV90eCgpLCBhbHdheXMgbG9jayByeCB2cSBiZWZvcmUgdHggdnEsIGFuZCB1bmxvY2sg aXQgaWYKPiA+ID4gPiA+ICAgICBidXN5IHBvbGxpbmcgaXMgbm90IGVuYWJsZWQuCj4gPiA+ID4g PiAtIFJlbW92ZSB0aGUgdHJpY2t5IGxvY2tpbmcgY29kZXMgaW4gYnVzeSBwb2xsaW5nLgo+ID4g PiA+ID4gCj4gPiA+ID4gPiBXaXRoIHRoaXMsIHdlIGNhbiBoYXZlIGEgZXhhY3Qgc2FtZSBsb2Nr IG9yZGVyaW5nIGZvciB2aG9zdF9uZXQsIHRoaXMKPiA+ID4gPiA+IGFsbG93cyB1cyB0byBzYWZl bHkgcmV2ZXJ0IGNvbW1pdCA3ODEzOWM5NGRjOGMgKCJuZXQ6IHZob3N0OiBsb2NrIHRoZQo+ID4g PiA+ID4gdnFzIG9uZSBieSBvbmUiKSBpbiBuZXh0IHBhdGNoLgo+ID4gPiA+ID4gCj4gPiA+ID4g PiBUaGUgcGF0Y2ggd2lsbCBhZGQgdHdvIG1vcmUgYXRvbWljIG9wZXJhdGlvbnMgb24gdGhlIHR4 IHBhdGggZHVyaW5nCj4gPiA+ID4gPiBlYWNoIHJvdW5kIG9mIGhhbmRsZV90eCgpLiAxIGJ5dGUg VENQX1JSIGRvZXMgbm90IG5vdGljZSBzdWNoCj4gPiA+ID4gPiBvdmVyaGVhZC4KPiA+ID4gPiA+ IAo+ID4gPiA+ID4gRml4ZXM6IGNvbW1pdCA3ODEzOWM5NGRjOGMgKCJuZXQ6IHZob3N0OiBsb2Nr IHRoZSB2cXMgb25lIGJ5IG9uZSIpCj4gPiA+ID4gPiBDYzogVG9uZ2hhbyBaaGFuZzx4aWFuZ3hp YS5tLnl1ZUBnbWFpbC5jb20+Cj4gPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBKYXNvbiBXYW5nPGph c293YW5nQHJlZGhhdC5jb20+Cj4gPiA+ID4gPiAtLS0KPiA+ID4gPiA+ICAgIGRyaXZlcnMvdmhv c3QvbmV0LmMgfCAxOCArKysrKysrKysrKysrKystLS0KPiA+ID4gPiA+ICAgIDEgZmlsZSBjaGFu Z2VkLCAxNSBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+ID4gPiA+ID4gCj4gPiA+ID4g PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy92aG9zdC9uZXQuYyBiL2RyaXZlcnMvdmhvc3QvbmV0LmMK PiA+ID4gPiA+IGluZGV4IGFiMTFiMmJlZTI3My4uNWYyNzJhYjRkNWI0IDEwMDY0NAo+ID4gPiA+ ID4gLS0tIGEvZHJpdmVycy92aG9zdC9uZXQuYwo+ID4gPiA+ID4gKysrIGIvZHJpdmVycy92aG9z dC9uZXQuYwo+ID4gPiA+ID4gQEAgLTUxMyw3ICs1MTMsNiBAQCBzdGF0aWMgdm9pZCB2aG9zdF9u ZXRfYnVzeV9wb2xsKHN0cnVjdCB2aG9zdF9uZXQgKm5ldCwKPiA+ID4gPiA+ICAgIAlzdHJ1Y3Qg c29ja2V0ICpzb2NrOwo+ID4gPiA+ID4gICAgCXN0cnVjdCB2aG9zdF92aXJ0cXVldWUgKnZxID0g cG9sbF9yeCA/IHR2cSA6IHJ2cTsKPiA+ID4gPiA+IC0JbXV0ZXhfbG9ja19uZXN0ZWQoJnZxLT5t dXRleCwgcG9sbF9yeCA/IFZIT1NUX05FVF9WUV9UWDogVkhPU1RfTkVUX1ZRX1JYKTsKPiA+ID4g PiA+ICAgIAl2aG9zdF9kaXNhYmxlX25vdGlmeSgmbmV0LT5kZXYsIHZxKTsKPiA+ID4gPiA+ICAg IAlzb2NrID0gcnZxLT5wcml2YXRlX2RhdGE7Cj4gPiA+ID4gPiBAQCAtNTQzLDggKzU0Miw2IEBA IHN0YXRpYyB2b2lkIHZob3N0X25ldF9idXN5X3BvbGwoc3RydWN0IHZob3N0X25ldCAqbmV0LAo+ ID4gPiA+ID4gICAgCQl2aG9zdF9uZXRfYnVzeV9wb2xsX3RyeV9xdWV1ZShuZXQsIHZxKTsKPiA+ ID4gPiA+ICAgIAllbHNlIGlmICghcG9sbF9yeCkgLyogT24gdHggaGVyZSwgc29jayBoYXMgbm8g cnggZGF0YS4gKi8KPiA+ID4gPiA+ICAgIAkJdmhvc3RfZW5hYmxlX25vdGlmeSgmbmV0LT5kZXYs IHJ2cSk7Cj4gPiA+ID4gPiAtCj4gPiA+ID4gPiAtCW11dGV4X3VubG9jaygmdnEtPm11dGV4KTsK PiA+ID4gPiA+ICAgIH0KPiA+ID4gPiA+ICAgIHN0YXRpYyBpbnQgdmhvc3RfbmV0X3R4X2dldF92 cV9kZXNjKHN0cnVjdCB2aG9zdF9uZXQgKm5ldCwKPiA+ID4gPiA+IEBAIC05MTMsMTAgKzkxMCwx NiBAQCBzdGF0aWMgdm9pZCBoYW5kbGVfdHhfemVyb2NvcHkoc3RydWN0IHZob3N0X25ldCAqbmV0 LCBzdHJ1Y3Qgc29ja2V0ICpzb2NrKQo+ID4gPiA+ID4gICAgc3RhdGljIHZvaWQgaGFuZGxlX3R4 KHN0cnVjdCB2aG9zdF9uZXQgKm5ldCkKPiA+ID4gPiA+ICAgIHsKPiA+ID4gPiA+ICAgIAlzdHJ1 Y3Qgdmhvc3RfbmV0X3ZpcnRxdWV1ZSAqbnZxID0gJm5ldC0+dnFzW1ZIT1NUX05FVF9WUV9UWF07 Cj4gPiA+ID4gPiArCXN0cnVjdCB2aG9zdF9uZXRfdmlydHF1ZXVlICpudnFfcnggPSAmbmV0LT52 cXNbVkhPU1RfTkVUX1ZRX1JYXTsKPiA+ID4gPiA+ICAgIAlzdHJ1Y3Qgdmhvc3RfdmlydHF1ZXVl ICp2cSA9ICZudnEtPnZxOwo+ID4gPiA+ID4gKwlzdHJ1Y3Qgdmhvc3RfdmlydHF1ZXVlICp2cV9y eCA9ICZudnFfcngtPnZxOwo+ID4gPiA+ID4gICAgCXN0cnVjdCBzb2NrZXQgKnNvY2s7Cj4gPiA+ ID4gPiArCW11dGV4X2xvY2tfbmVzdGVkKCZ2cV9yeC0+bXV0ZXgsIFZIT1NUX05FVF9WUV9SWCk7 Cj4gPiA+ID4gPiAgICAJbXV0ZXhfbG9ja19uZXN0ZWQoJnZxLT5tdXRleCwgVkhPU1RfTkVUX1ZR X1RYKTsKPiA+ID4gPiA+ICsJaWYgKCF2cS0+YnVzeWxvb3BfdGltZW91dCkKPiA+ID4gPiA+ICsJ CW11dGV4X3VubG9jaygmdnFfcngtPm11dGV4KTsKPiA+ID4gPiA+ICsKPiA+ID4gPiA+ICAgIAlz b2NrID0gdnEtPnByaXZhdGVfZGF0YTsKPiA+ID4gPiA+ICAgIAlpZiAoIXNvY2spCj4gPiA+ID4g PiAgICAJCWdvdG8gb3V0Owo+ID4gPiA+ID4gQEAgLTkzMyw2ICs5MzYsOCBAQCBzdGF0aWMgdm9p ZCBoYW5kbGVfdHgoc3RydWN0IHZob3N0X25ldCAqbmV0KQo+ID4gPiA+ID4gICAgCQloYW5kbGVf dHhfY29weShuZXQsIHNvY2spOwo+ID4gPiA+ID4gICAgb3V0Ogo+ID4gPiA+ID4gKwlpZiAodnEt PmJ1c3lsb29wX3RpbWVvdXQpCj4gPiA+ID4gPiArCQltdXRleF91bmxvY2soJnZxX3J4LT5tdXRl eCk7Cj4gPiA+ID4gPiAgICAJbXV0ZXhfdW5sb2NrKCZ2cS0+bXV0ZXgpOwo+ID4gPiA+ID4gICAg fQo+ID4gPiA+IFNvIHJ4IG11dGV4IHRha2VuIG9uIHR4IHBhdGggbm93LiAgQW5kIHR4IG11dGV4 IGlzIG9uIHJjIHBhdGggLi4uICBUaGlzCj4gPiA+ID4gaXMganVzdCBtZXNzZWQgdXAuIFdoeSBj YW4ndCB0eCBwb2xsaW5nIGRyb3AgcnggbG9jayBiZWZvcmUKPiA+ID4gPiBnZXR0aW5nIHRoZSB0 eCBsb2NrIGFuZCB2aWNlIHZlcnNhPwo+ID4gPiAKPiA+ID4gQmVjYXVzZSB3ZSB3YW50IHRvIHBv bGwgYm90aCB0eCBhbmQgcnggdmlydHF1ZXVlIGF0IHRoZSBzYW1lIHRpbWUKPiA+ID4gKHZob3N0 X25ldF9idXN5X3BvbGwoKSkuCj4gPiA+IAo+ID4gPiAgwqDCoMKgIHdoaWxlICh2aG9zdF9jYW5f YnVzeV9wb2xsKGVuZHRpbWUpKSB7Cj4gPiA+ICDCoMKgIMKgwqDCoCDCoGlmICh2aG9zdF9oYXNf d29yaygmbmV0LT5kZXYpKSB7Cj4gPiA+ICDCoMKgIMKgwqDCoCDCoMKgwqAgwqAqYnVzeWxvb3Bf aW50ciA9IHRydWU7Cj4gPiA+ICDCoMKgIMKgwqDCoCDCoMKgwqAgwqBicmVhazsKPiA+ID4gIMKg wqAgwqDCoMKgIMKgfQo+ID4gPiAKPiA+ID4gIMKgwqAgwqDCoMKgIMKgaWYgKChzb2NrX2hhc19y eF9kYXRhKHNvY2spICYmCj4gPiA+ICDCoMKgIMKgwqDCoCDCoMKgwqDCoMKgICF2aG9zdF92cV9h dmFpbF9lbXB0eSgmbmV0LT5kZXYsIHJ2cSkpIHx8Cj4gPiA+ICDCoMKgIMKgwqDCoCDCoMKgwqDC oCAhdmhvc3RfdnFfYXZhaWxfZW1wdHkoJm5ldC0+ZGV2LCB0dnEpKQo+ID4gPiAgwqDCoCDCoMKg wqAgwqDCoMKgIMKgYnJlYWs7Cj4gPiA+IAo+ID4gPiAgwqDCoCDCoMKgwqAgwqBjcHVfcmVsYXgo KTsKPiA+ID4gCj4gPiA+ICDCoMKgIMKgfQo+ID4gPiAKPiA+ID4gCj4gPiA+IEFuZCB3ZSBkaXNh YmxlIGtpY2tzIGFuZCBub3RpZmljYXRpb24gZm9yIGJldHRlciBwZXJmb3JtYW5jZS4KPiA+IFJp Z2h0IGJ1dCBpdCdzIGFsbCBzbG93IHBhdGggLSBpdCBoYXBwZW5zIHdoZW4gcXVldWUgaXMKPiA+ IG90aGVyd2lzZSBlbXB0eS4gU28gdGhpcyBpcyB3aGF0IEkgYW0gc2F5aW5nOiBsZXQncyBkcm9w IHRoZSBsb2Nrcwo+ID4gd2UgaG9sZCBhcm91bmQgdGhpcy4KPiAKPiAKPiBJcyB0aGlzIHJlYWxs eSBzYWZlPyBJIGxvb2tzIHRvIG1lIGl0IGNhbiByYWNlIHdpdGggU0VUX1ZSSU5HX0FERFIuIEFu ZCB0aGUKPiBjb2RlcyBkaWQgbW9yZToKPiAKPiAtIGFjY2VzcyBzb2NrIG9iamVjdAo+IAo+IC0g YWNjZXNzIGRldmljZSBJT1RMQgo+IAo+IC0gZW5hYmxlIGFuZCBkaXNhYmxlIG5vdGlmaWNhdGlv bgo+IAo+IE5vbmUgb2YgYWJvdmUgaXMgc2FmZSB3aXRob3V0IHRoZSBwcm90ZWN0aW9uIG9mIHZx IG11dGV4LgoKCnlzIGJ1dCB0YWtlIGFub3RoZXIgbG9jay4ganVzdCBub3QgbmVzdGVkLgoKCj4g Cj4gPiAKPiA+IAo+ID4gPiA+IE9yIGlmIHdlIHJlYWxseSB3YW50ZWQgdG8gZm9yY2UgZXZlcnl0 aGluZyB0byBiZSBsb2NrZWQgYXQKPiA+ID4gPiBhbGwgdGltZXMsIGxldCdzIGp1c3QgdXNlIGEg c2luZ2xlIG11dGV4Lgo+ID4gPiA+IAo+ID4gPiA+IAo+ID4gPiA+IAo+ID4gPiBXZSBjb3VsZCwg YnV0IGl0IG1pZ2h0IHJlcXVpcmVzIG1vcmUgY2hhbmdlcyB3aGljaCBjb3VsZCBiZSBkb25lIGZv ciAtbmV4dCBJCj4gPiA+IGJlbGlldmUuCj4gPiA+IAo+ID4gPiAKPiA+ID4gVGhhbmtzCj4gPiBJ J2QgcmF0aGVyIHdlIGtlcHQgdGhlIGZpbmUgZ3JhaW5lZCBsb2NraW5nLiBFLmcuIHBlb3BsZSBh cmUKPiA+IGxvb2tpbmcgYXQgc3BsaXR0aW5nIHRoZSB0eCBhbmQgcnggdGhyZWFkcy4gQnV0IGlm IG5vdCBwb3NzaWJsZQo+ID4gbGV0J3MgZml4IGl0IGNsZWFubHkgd2l0aCBhIGNvYXJzZS1ncmFp bmVkIG9uZS4gQSBtZXNzIGhlcmUgd2lsbAo+ID4ganVzdCBjcmVhdGUgbW9yZSB0cm91YmxlIGxh dGVyLgo+ID4gCj4gCj4gSSBiZWxpZXZlIHdlIHdvbid0IGdvIGJhY2sgdG8gY29hcnNlIG9uZS4g TG9va3MgbGlrZSB3ZSBjYW4gc29sdmUgdGhpcyBieQo+IHVzaW5nIG11dGV4X3RyeWxvY2soKSBm b3IgcnhxIGR1cmluZyBUWC4gQW5kIGRvbid0IGRvIHBvbGxpbmcgZm9yIHJ4cSBpcyBhCj4gSU9U TEIgdXBkYXRpbmcgaXMgcGVuZGluZy4KPiAKPiBMZXQgbWUgcG9zdCBWMi4KPiAKPiBUaGFua3MK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KVmlydHVhbGl6 YXRpb24gbWFpbGluZyBsaXN0ClZpcnR1YWxpemF0aW9uQGxpc3RzLmxpbnV4LWZvdW5kYXRpb24u b3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL3Zp cnR1YWxpemF0aW9u From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88BD1C65BAF for ; Wed, 12 Dec 2018 03:40:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 447542086D for ; Wed, 12 Dec 2018 03:40:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 447542086D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726382AbeLLDks (ORCPT ); Tue, 11 Dec 2018 22:40:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42940 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726220AbeLLDkr (ORCPT ); Tue, 11 Dec 2018 22:40:47 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E1B72A4026; Wed, 12 Dec 2018 03:40:46 +0000 (UTC) Received: from redhat.com (ovpn-120-67.rdu2.redhat.com [10.10.120.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id 16908600C9; Wed, 12 Dec 2018 03:40:45 +0000 (UTC) Date: Tue, 11 Dec 2018 22:40:45 -0500 From: "Michael S. Tsirkin" To: Jason Wang Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Tonghao Zhang Subject: Re: [PATCH net 2/4] vhost_net: rework on the lock ordering for busy polling Message-ID: <20181211224024-mutt-send-email-mst@kernel.org> References: <20181210094454.21144-1-jasowang@redhat.com> <20181210094454.21144-3-jasowang@redhat.com> <20181210203119-mutt-send-email-mst@kernel.org> <20181210230106-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 12 Dec 2018 03:40:47 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 12, 2018 at 11:03:57AM +0800, Jason Wang wrote: > > On 2018/12/11 下午12:04, Michael S. Tsirkin wrote: > > On Tue, Dec 11, 2018 at 11:06:43AM +0800, Jason Wang wrote: > > > On 2018/12/11 上午9:34, Michael S. Tsirkin wrote: > > > > On Mon, Dec 10, 2018 at 05:44:52PM +0800, Jason Wang wrote: > > > > > When we try to do rx busy polling in tx path in commit 441abde4cd84 > > > > > ("net: vhost: add rx busy polling in tx path"), we lock rx vq mutex > > > > > after tx vq mutex is held. This may lead deadlock so we try to lock vq > > > > > one by one in commit 78139c94dc8c ("net: vhost: lock the vqs one by > > > > > one"). With this commit, we avoid the deadlock with the assumption > > > > > that handle_rx() and handle_tx() run in a same process. But this > > > > > commit remove the protection for IOTLB updating which requires the > > > > > mutex of each vq to be held. > > > > > > > > > > To solve this issue, the first step is to have a exact same lock > > > > > ordering for vhost_net. This is done through: > > > > > > > > > > - For handle_rx(), if busy polling is enabled, lock tx vq immediately. > > > > > - For handle_tx(), always lock rx vq before tx vq, and unlock it if > > > > > busy polling is not enabled. > > > > > - Remove the tricky locking codes in busy polling. > > > > > > > > > > With this, we can have a exact same lock ordering for vhost_net, this > > > > > allows us to safely revert commit 78139c94dc8c ("net: vhost: lock the > > > > > vqs one by one") in next patch. > > > > > > > > > > The patch will add two more atomic operations on the tx path during > > > > > each round of handle_tx(). 1 byte TCP_RR does not notice such > > > > > overhead. > > > > > > > > > > Fixes: commit 78139c94dc8c ("net: vhost: lock the vqs one by one") > > > > > Cc: Tonghao Zhang > > > > > Signed-off-by: Jason Wang > > > > > --- > > > > > drivers/vhost/net.c | 18 +++++++++++++++--- > > > > > 1 file changed, 15 insertions(+), 3 deletions(-) > > > > > > > > > > diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c > > > > > index ab11b2bee273..5f272ab4d5b4 100644 > > > > > --- a/drivers/vhost/net.c > > > > > +++ b/drivers/vhost/net.c > > > > > @@ -513,7 +513,6 @@ static void vhost_net_busy_poll(struct vhost_net *net, > > > > > struct socket *sock; > > > > > struct vhost_virtqueue *vq = poll_rx ? tvq : rvq; > > > > > - mutex_lock_nested(&vq->mutex, poll_rx ? VHOST_NET_VQ_TX: VHOST_NET_VQ_RX); > > > > > vhost_disable_notify(&net->dev, vq); > > > > > sock = rvq->private_data; > > > > > @@ -543,8 +542,6 @@ static void vhost_net_busy_poll(struct vhost_net *net, > > > > > vhost_net_busy_poll_try_queue(net, vq); > > > > > else if (!poll_rx) /* On tx here, sock has no rx data. */ > > > > > vhost_enable_notify(&net->dev, rvq); > > > > > - > > > > > - mutex_unlock(&vq->mutex); > > > > > } > > > > > static int vhost_net_tx_get_vq_desc(struct vhost_net *net, > > > > > @@ -913,10 +910,16 @@ static void handle_tx_zerocopy(struct vhost_net *net, struct socket *sock) > > > > > static void handle_tx(struct vhost_net *net) > > > > > { > > > > > struct vhost_net_virtqueue *nvq = &net->vqs[VHOST_NET_VQ_TX]; > > > > > + struct vhost_net_virtqueue *nvq_rx = &net->vqs[VHOST_NET_VQ_RX]; > > > > > struct vhost_virtqueue *vq = &nvq->vq; > > > > > + struct vhost_virtqueue *vq_rx = &nvq_rx->vq; > > > > > struct socket *sock; > > > > > + mutex_lock_nested(&vq_rx->mutex, VHOST_NET_VQ_RX); > > > > > mutex_lock_nested(&vq->mutex, VHOST_NET_VQ_TX); > > > > > + if (!vq->busyloop_timeout) > > > > > + mutex_unlock(&vq_rx->mutex); > > > > > + > > > > > sock = vq->private_data; > > > > > if (!sock) > > > > > goto out; > > > > > @@ -933,6 +936,8 @@ static void handle_tx(struct vhost_net *net) > > > > > handle_tx_copy(net, sock); > > > > > out: > > > > > + if (vq->busyloop_timeout) > > > > > + mutex_unlock(&vq_rx->mutex); > > > > > mutex_unlock(&vq->mutex); > > > > > } > > > > So rx mutex taken on tx path now. And tx mutex is on rc path ... This > > > > is just messed up. Why can't tx polling drop rx lock before > > > > getting the tx lock and vice versa? > > > > > > Because we want to poll both tx and rx virtqueue at the same time > > > (vhost_net_busy_poll()). > > > > > >     while (vhost_can_busy_poll(endtime)) { > > >         if (vhost_has_work(&net->dev)) { > > >             *busyloop_intr = true; > > >             break; > > >         } > > > > > >         if ((sock_has_rx_data(sock) && > > >              !vhost_vq_avail_empty(&net->dev, rvq)) || > > >             !vhost_vq_avail_empty(&net->dev, tvq)) > > >             break; > > > > > >         cpu_relax(); > > > > > >     } > > > > > > > > > And we disable kicks and notification for better performance. > > Right but it's all slow path - it happens when queue is > > otherwise empty. So this is what I am saying: let's drop the locks > > we hold around this. > > > Is this really safe? I looks to me it can race with SET_VRING_ADDR. And the > codes did more: > > - access sock object > > - access device IOTLB > > - enable and disable notification > > None of above is safe without the protection of vq mutex. ys but take another lock. just not nested. > > > > > > > > > Or if we really wanted to force everything to be locked at > > > > all times, let's just use a single mutex. > > > > > > > > > > > > > > > We could, but it might requires more changes which could be done for -next I > > > believe. > > > > > > > > > Thanks > > I'd rather we kept the fine grained locking. E.g. people are > > looking at splitting the tx and rx threads. But if not possible > > let's fix it cleanly with a coarse-grained one. A mess here will > > just create more trouble later. > > > > I believe we won't go back to coarse one. Looks like we can solve this by > using mutex_trylock() for rxq during TX. And don't do polling for rxq is a > IOTLB updating is pending. > > Let me post V2. > > Thanks