From: Tony Lindgren <tony@atomide.com>
To: Ricardo Salveti <rsalveti@rsalveti.net>
Cc: John Stultz <john.stultz@linaro.org>,
linux-wireless@vger.kernel.org, anders.roxell@linaro.org
Subject: Re: wlcore getting stuck on hikey after the runtime PM autosuspend support change
Date: Tue, 11 Dec 2018 17:25:39 -0800 [thread overview]
Message-ID: <20181212012539.GA39861@atomide.com> (raw)
In-Reply-To: <CAHYQr0onAAMZ21YU59XOgNsVrZ-+33tUHfOa9aPr+hG2M0zb3g@mail.gmail.com>
* Ricardo Salveti <rsalveti@rsalveti.net> [181211 21:51]:
> Tried to change back wl12xx_sdio_power_off to use pm_runtime_put_sync
> as a test, and noticed I always get -EBUSY when reproducing the hang,
> so it looks like this could be a race between pm_runtime_put/get when
> doing if down/up (and the side effect on the mmc controller).
Hmm so -EBUSY for pm_runtime means transition is already happening
and in many cases the test should be:
error = pm_runtime_get(dev);
if (error < 0 && error != -EBUSY) {
...
}
...
pm_runtime_put(dev);
Where are you getting it?
Regards,
Tony
next prev parent reply other threads:[~2018-12-12 1:25 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 18:06 wlcore getting stuck on hikey after the runtime PM autosuspend support change Ricardo Salveti
2018-12-11 18:19 ` Tony Lindgren
2018-12-11 18:52 ` Ricardo Salveti
2018-12-11 19:01 ` Tony Lindgren
2018-12-11 19:25 ` Ricardo Salveti
2018-12-11 19:50 ` John Stultz
2018-12-11 20:12 ` Tony Lindgren
2018-12-11 20:23 ` Ricardo Salveti
2018-12-11 20:44 ` Ricardo Salveti
2018-12-12 1:45 ` Tony Lindgren
2018-12-12 7:27 ` [EXTERNAL] " Reizer, Eyal
2018-12-12 18:31 ` Tony Lindgren
2018-12-12 19:24 ` Ricardo Salveti
2018-12-13 7:49 ` Reizer, Eyal
2018-12-13 13:52 ` Ricardo Salveti
2018-12-13 14:45 ` Tony Lindgren
2018-12-13 14:53 ` Reizer, Eyal
2018-12-13 14:55 ` Ricardo Salveti
2018-12-14 20:41 ` Ricardo Salveti
2018-12-14 23:28 ` Tony Lindgren
2018-12-15 3:37 ` Ricardo Salveti
2018-12-17 14:45 ` Tony Lindgren
2018-12-12 19:16 ` Ricardo Salveti
2018-12-11 21:50 ` Ricardo Salveti
2018-12-11 23:44 ` Anders Roxell
2018-12-12 18:33 ` Tony Lindgren
2018-12-17 9:36 ` Anders Roxell
2018-12-12 1:25 ` Tony Lindgren [this message]
2018-12-12 19:20 ` Ricardo Salveti
2018-12-11 19:13 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212012539.GA39861@atomide.com \
--to=tony@atomide.com \
--cc=anders.roxell@linaro.org \
--cc=john.stultz@linaro.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rsalveti@rsalveti.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.