From: Tom Burkart <tom@aussec.com>
To: Linux kernel mailing list <linux-kernel@vger.kernel.org>
Cc: Tom Burkart <tom@aussec.com>
Subject: [PATCH v12 0/3] PPS: pps-gpio PPS ECHO implementation
Date: Wed, 12 Dec 2018 13:52:11 +1100 [thread overview]
Message-ID: <20181212025214.29911-1-tom@aussec.com> (raw)
Hi all,
please find attached the PPS-GPIO PPS ECHO implementation patch. The
driver claims to have echo functionality in the sysfs interface but this
functionality is not present. This patch provides this functionality.
Part 1 of the patch change the original driver from the number
based GPIO ABI to the descriptor based ABI.
Parts 2 and 3 then add the PPS ECHO functionality. This is enabled if a
"echo-gpios" entry is found in the devicetree.
Changes in v8:
Changes requested by Rob Herring and Philipp Zabel:
DT explanation and don't change the DT entry for the PPS gpio.
Changes in v9:
Simplify "if" expression by doing echo_active_ms validation earlier.
Changes in v10:
Changes requested by Philipp Zabel:
Mostly cosmetic changes: PATCH 2/4 now reviewed. Thanks a lot, Philipp!
(Please note that as of v11 PATCH 1 is gone so this has become PATCH 1)
Change in v11:
Change requested by Rob Herring:
All changes in regard to the capture-clear DT entry are gone.
Change in v12:
Change requested by Rob Herring:
Deleted superfluous use of invert-pps-echo
On the linuxpps mailing list it was suggested to use a hrtimer for
resetting the GPIO ECHO active state to the inactive state.
Please also comment on whether a hrtimer is necessary/desirable for the
purpose of resetting the echo pin active state. I am happy to implement
it if this is useful/desirable.
Please install, test and comment as it is now a quite major change to
the driver.
Suggestions for improvement are welcome.
Tom Burkart
Tom Burkart (3):
pps: descriptor-based gpio
dt-bindings: pps: pps-gpio PPS ECHO implementation
pps: pps-gpio pps-echo implementation
Documentation/devicetree/bindings/pps/pps-gpio.txt | 7 +
drivers/pps/clients/pps-gpio.c | 159 ++++++++++++++++-----
include/linux/pps-gpio.h | 5 +-
3 files changed, 131 insertions(+), 40 deletions(-)
--
2.12.3
next reply other threads:[~2018-12-12 2:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 2:52 Tom Burkart [this message]
2018-12-12 2:52 ` [PATCH v12 1/3] pps: descriptor-based gpio Tom Burkart
2018-12-12 2:52 ` [PATCH v12 2/3] dt-bindings: pps: pps-gpio PPS ECHO implementation Tom Burkart
2018-12-12 2:52 ` [PATCH v12 3/3] pps: pps-gpio pps-echo implementation Tom Burkart
2018-12-12 14:01 ` [PATCH v12 2/3] dt-bindings: pps: pps-gpio PPS ECHO implementation Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212025214.29911-1-tom@aussec.com \
--to=tom@aussec.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.