From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
linux-rdma@vger.kernel.org, Keith Busch <keith.busch@intel.com>
Subject: Re: [PATCH RFC 4/4] nvme-multipath: disable polling for underlying namespace request queue
Date: Wed, 12 Dec 2018 08:21:32 +0100 [thread overview]
Message-ID: <20181212072132.GA28850@lst.de> (raw)
In-Reply-To: <d0d76a09-7ec9-2018-d4ce-7a08d4ab4002@grimberg.me>
On Tue, Dec 11, 2018 at 11:19:22PM -0800, Sagi Grimberg wrote:
>> So we need to make sure in the block layer or I/O submitter that
>> REQ_HIPRI is only set if QUEUE_FLAG_POLL is supported. I think it would
>> also help if we rename it to REQ_POLL to make this more obvious.
>
> It used to check for it, but was changed to look at nr_maps instead...
> So I think this is a regression...
blk_mq_map_queue looks at both QUEUE_FLAG_POLL and nr_maps for the
queue selection, but that doesn't help with the problem that we should
never pass poll requests through stacking devices.
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH RFC 4/4] nvme-multipath: disable polling for underlying namespace request queue
Date: Wed, 12 Dec 2018 08:21:32 +0100 [thread overview]
Message-ID: <20181212072132.GA28850@lst.de> (raw)
In-Reply-To: <d0d76a09-7ec9-2018-d4ce-7a08d4ab4002@grimberg.me>
On Tue, Dec 11, 2018@11:19:22PM -0800, Sagi Grimberg wrote:
>> So we need to make sure in the block layer or I/O submitter that
>> REQ_HIPRI is only set if QUEUE_FLAG_POLL is supported. I think it would
>> also help if we rename it to REQ_POLL to make this more obvious.
>
> It used to check for it, but was changed to look at nr_maps instead...
> So I think this is a regression...
blk_mq_map_queue looks at both QUEUE_FLAG_POLL and nr_maps for the
queue selection, but that doesn't help with the problem that we should
never pass poll requests through stacking devices.
next prev parent reply other threads:[~2018-12-12 7:21 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 23:36 [PATCH RFC 0/4] restore polling to nvme-rdma Sagi Grimberg
2018-12-11 23:36 ` Sagi Grimberg
2018-12-11 23:36 ` [PATCH RFC 1/4] nvme-fabrics: allow user to pass in nr_poll_queues Sagi Grimberg
2018-12-11 23:36 ` Sagi Grimberg
2018-12-11 23:36 ` [PATCH RFC 2/4] rdma: introduce ib_change_cq_ctx Sagi Grimberg
2018-12-11 23:36 ` Sagi Grimberg
2018-12-11 23:36 ` [PATCH RFC 3/4] nvme-rdma: implement polling queue map Sagi Grimberg
2018-12-11 23:36 ` Sagi Grimberg
2018-12-11 23:36 ` [PATCH RFC 4/4] nvme-multipath: disable polling for underlying namespace request queue Sagi Grimberg
2018-12-11 23:36 ` Sagi Grimberg
2018-12-12 7:11 ` Christoph Hellwig
2018-12-12 7:11 ` Christoph Hellwig
2018-12-12 7:19 ` Sagi Grimberg
2018-12-12 7:19 ` Sagi Grimberg
2018-12-12 7:21 ` Christoph Hellwig [this message]
2018-12-12 7:21 ` Christoph Hellwig
2018-12-12 7:29 ` Sagi Grimberg
2018-12-12 7:29 ` Sagi Grimberg
2018-12-12 7:37 ` Christoph Hellwig
2018-12-12 7:37 ` Christoph Hellwig
2018-12-11 23:36 ` [PATCH RFC nvme-cli 5/4] fabrics: pass in number of polling queues Sagi Grimberg
2018-12-11 23:36 ` Sagi Grimberg
2018-12-12 0:27 ` Sagi Grimberg
2018-12-12 0:27 ` Sagi Grimberg
2018-12-12 7:07 ` [PATCH RFC 0/4] restore polling to nvme-rdma Christoph Hellwig
2018-12-12 7:07 ` Christoph Hellwig
2018-12-12 7:16 ` Sagi Grimberg
2018-12-12 7:16 ` Sagi Grimberg
2018-12-12 8:09 ` Christoph Hellwig
2018-12-12 8:09 ` Christoph Hellwig
2018-12-12 8:53 ` Sagi Grimberg
2018-12-12 8:53 ` Sagi Grimberg
2018-12-12 14:05 ` Christoph Hellwig
2018-12-12 14:05 ` Christoph Hellwig
2018-12-12 18:23 ` Sagi Grimberg
2018-12-12 18:23 ` Sagi Grimberg
2018-12-12 16:37 ` Steve Wise
2018-12-12 16:37 ` Steve Wise
2018-12-12 18:05 ` Sagi Grimberg
2018-12-12 18:05 ` Sagi Grimberg
2018-12-12 18:10 ` Steve Wise
2018-12-12 18:10 ` Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212072132.GA28850@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.