From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 2/2] nvme-rdma: Handle completions if error_recovery fails
Date: Wed, 12 Dec 2018 09:12:37 +0100 [thread overview]
Message-ID: <20181212081237.GC29679@lst.de> (raw)
In-Reply-To: <24f0d05c-b309-a00d-ddd3-f13f0ac74268@grimberg.me>
On Tue, Dec 11, 2018@11:56:26PM -0800, Sagi Grimberg wrote:
> Can't you live with just the two hunks above? and in the timeout
> handler you need to stop the queue before you complete the I/O to
> barrier against competing completions.
>
> Also, lets get rid of DNR while we're at it.
>
> I don't see why you need the others... I need further explanation for
> that.
Agreed. Also there is a lot of churn here, some of it needs to be
split into well described self-contained prep patches.
next prev parent reply other threads:[~2018-12-12 8:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 6:55 [PATCH 1/2] nvme: Introduce nvme_is_aen_req function Nitzan Carmi
2018-12-12 6:55 ` [PATCH 2/2] nvme-rdma: Handle completions if error_recovery fails Nitzan Carmi
2018-12-12 7:56 ` Sagi Grimberg
2018-12-12 8:12 ` Christoph Hellwig [this message]
2018-12-12 7:46 ` [PATCH 1/2] nvme: Introduce nvme_is_aen_req function Sagi Grimberg
2018-12-12 8:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212081237.GC29679@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.